Release/public-v2: Bugfix for lmodsetup files on noaacloud#302
Merged
gspetro-NOAA merged 254 commits intoJun 13, 2022
Merged
Conversation
gspetro-NOAA
requested review from
BenjaminBlake-NOAA,
EdwardSnyder-NOAA,
JeffBeck-NOAA,
RatkoVasic-NOAA,
chan-hoo,
christinaholtNOAA,
christopherwharrop-noaa,
danielabdi-noaa,
dmwright526,
gsketefian,
jkbk2004,
mark-a-potts,
mkavulich,
natalie-perlin,
panll,
willmayfield and
ywangwof
as code owners
JeffBeck-NOAA
approved these changes
Jun 10, 2022
Collaborator
|
@gspetro-NOAA - There are a number of files changing in the hpc-stack-mod directory. Did you intend to include these changes with this PR? |
Collaborator
Author
@EdwardSnyder-NOAA Yes--I had updated the HPC-Stack submodule, so those changes came in. Seemed like a pain to undo them, and no harm done if they come in, since it will catch any minor doc updates (that's why I updated in the first place). The submodule isn't used for anything but the docs, so any changes in HPC-Stack functionality should have no direct impact. |
Collaborator
|
@gspetro-NOAA Okay, just wanted to make sure. I'll approve the PR. |
EdwardSnyder-NOAA
approved these changes
Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
On NOAA Cloud's GCP and Azure systems, use of the current lmod-setup files produces a problem finding the Lmod path. Removing the noaacloud stanza from lmod-setup fixes the problem.
Also updates hash of regional_workflow to HEAD of release/public-v2.
TESTS CONDUCTED:
Built SRW App successfully from the release branch with devbuild.sh method on AWS, GCP, Azure.
Bruce Kropp also confirmed the builds.
DOCUMENTATION:
N/A
CONTRIBUTORS (optional):
@natalie-perlin @EdwardSnyder-NOAA @ulmononian Bruce Kropp