Release/public v2 jet bugfix#286
Merged
mark-a-potts merged 10 commits intoJun 1, 2022
Merged
Conversation
… SRW release/public-v2
The slash in branch names such as release/.* and feature/.* is interpreted as a directory separator. This change replaces the "/" character with a "_".
Modulefiles load software libraries and activate python virtual environment
Release/public v2 UFS-COMMUNITY SRW repo - current
Module load miniconda3 from /contrib/... Prepend module path /contrib/miniconda3/modulefiles/ to the PATH (not _append_)
natalie-perlin
requested review from
BenjaminBlake-NOAA,
EdwardSnyder-NOAA,
JeffBeck-NOAA,
RatkoVasic-NOAA,
chan-hoo,
christinaholtNOAA,
christopherwharrop-noaa,
danielabdi-noaa,
dmwright526,
gsketefian,
gspetro-NOAA,
jkbk2004,
mark-a-potts,
mkavulich,
panll,
willmayfield and
ywangwof
as code owners
JeffBeck-NOAA
approved these changes
Jun 1, 2022
Collaborator
JeffBeck-NOAA
left a comment
JeffBeck-NOAA
left a comment
There was a problem hiding this comment.
@natalie-perlin, do you mind opening this same PR into the develop branch as well? Thanks!
dshawul
approved these changes
Jun 1, 2022
danielabdi-noaa
approved these changes
Jun 1, 2022
Adding a specific version of miniconda3/4.5.12 to be loaded, to avoid ambiguities with several available via /contrib/ and /hpc-stack/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Fixed the issue on running SRW on Jet: loading a specific version of miniconda3/4.5.12 from /contrib/., which was used to create a conda environment "regional_workflow". Prepending the path of /contrib/miniconda3/modulefiles to the $MODULEPATH and having it before the modulefiles hpc-stack directory did not solve the issue (see item 2. below, an earlier attempt)
Earlier attempt to solve: load the miniconda3 from the /contrib/ modulefiles, not the module built with the HPC-stack. Use of "
module load -a /contrib/miniconda3/modulefiles/" caused the module path to be appended to the search PATH, and the module path for the hpc-stack takes precedence when loading miniconda3.It did not help to solve the problem, because the miniconda3 in hpc-stack was labeled as a "default" module, regardless of the order in the MODULEPATH. Directory
/lfs4/HFIP/hfv3gfs/nwprod/hpc-stack/libs/modulefiles/core/miniconda3/on Jet contains the following files:TESTS CONDUCTED:
Making this PR to test if the issue with running SRW tests on Jet could be solved with fixing the correct miniconda3 module loaded, which needs to be the same module used to create the environment 'regional_workflow'.
Tests through Jenkins were successful:
Jenkins-build-srw-jet-intel
Jenkins-srw-e2e-tests
ISSUE (optional):
There were problems with running SRW tests on Jet after the recent HPC-stack update, with miniconda3 module becoming available in the hpc-stack build, as well as in /contrib/miniconda3/modulefiles.
CONTRIBUTORS:
@mark-a-potts , @BruceKropp-Raytheon