Replace deprecated app.add_stylesheet with app.add_css_file.#160
Merged
JulieSchramm merged 1 commit intoJul 28, 2021
Conversation
Collaborator
|
@JulieSchramm Can you say in the PR why this change was needed? Did |
jwolff-ncar
approved these changes
Jul 28, 2021
christinaholtNOAA
added a commit
to christinaholtNOAA/ufs-srweather-app
that referenced
this pull request
Jun 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Replace app.add_stylesheet with app.add_csss_file for ReadTheDocs build for the develop branch. This is needed to fix:
Running Sphinx v4.1.1
loading translations [en]... done
making output directory... done
Traceback (most recent call last):
File "/home/docs/checkouts/readthedocs.org/user_builds/ufs-srweather-app/envs/latest/lib/python3.7/site-packages/sphinx/cmd/build.py", line 279, in build_main
args.tags, args.verbosity, args.jobs, args.keep_going)
File "/home/docs/checkouts/readthedocs.org/user_builds/ufs-srweather-app/envs/latest/lib/python3.7/site-packages/sphinx/application.py", line 251, in init
self.config.setup(self)
File "/home/docs/checkouts/readthedocs.org/user_builds/ufs-srweather-app/checkouts/latest/docs/UsersGuide/source/conf.py", line 113, in setup
app.add_stylesheet('custom.css') # may also be an URL
AttributeError: 'Sphinx' object has no attribute 'add_stylesheet'
Exception occurred:
File "/home/docs/checkouts/readthedocs.org/user_builds/ufs-srweather-app/checkouts/latest/docs/UsersGuide/source/conf.py", line 113, in setup
app.add_stylesheet('custom.css') # may also be an URL
AttributeError: 'Sphinx' object has no attribute 'add_stylesheet'
The full traceback has been saved in /tmp/sphinx-err-5n19bai9.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at https://github.com/sphinx-doc/sphinx/issues. Thanks!
TESTS CONDUCTED:
HTML builds on MacOS
DEPENDENCIES:
None
DOCUMENTATION:
This fixes the documentation