[develop] Updates for fire behavior model: OpenMP parallelization; new wind option#1367
Merged
MichaelLueken merged 18 commits intoMar 20, 2026
Conversation
…ted for compile yet)
needed by the run_fcst task
mkavulich
force-pushed
the
feature/ufs_fire_openmp_windinterp_updates
branch
from
2c6e448 to
0673d57
Compare
mkavulich
requested review from
EdwardSnyder-NOAA,
JeffBeck-NOAA,
MichaelLueken,
RatkoVasic-NOAA,
chan-hoo,
christinaholtNOAA,
gsketefian,
gspetro-NOAA,
jkbk2004,
natalie-perlin,
panll and
ywangwof
as code owners
mkavulich
requested review from
WeirAE,
benkozi,
jdkublnick,
priyarpillai,
rickgrubin-noaa and
selbigmtnwx23
as code owners
MichaelLueken
changed the title
comprehensive.derecho - Uncomment grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR WE2E test comprehensive.hera.gnu - Same comprehensive.hera.intel - Same comprehensive.noaacloud - Same comprehensive.orion - Same comprehensive.ursa.gnu - Same comprehensive.ursa.intel - Same coverage.hercules - Same
Collaborator
|
@mkavulich - Since this PR is updating the ufs-weather-model to a later version, this PR will supersede my PR #1365. I will open a PR into your |
Collaborator
|
@mkavulich - PR #5 has been opened in your repository. |
…interp_updates Uncomment WE2E test following bugfix in the weather model
Collaborator
Author
|
Looks good to me @MichaelLueken, I merged those changes in. |
This was
linked to
issues
Mar 17, 2026
14 tasks
Collaborator
|
Comprehensive WE2E tests passed on Orion: UFS Fire WE2E tests passed on Orion: AQM WE2E test passed on Orion: |
Collaborator
|
The comprehensive WE2E test successfully ran on Ursa Intel: The UFS Fire WE2E tests successfully passed on Ursa Intel: The AQM WE2E test successfully passed on Ursa Intel: |
Collaborator
|
The Fundamental WE2E tests successfully passed on Ursa GNU: The UFS Fire WE2E tests successfully passed on Ursa GNU: |
Collaborator
|
The Comprehensive WE2E tests have successfully passed on Gaea C6: The UFS Fire WE2E tests have successfully passed on Gaea C6: The AQM WE2E test has successfully passed on Gaea C6: |
Collaborator
|
The Comprehensive WE2E tests have successfully passed on Hercules: The UFS Fire WE2E tests have successfully passed on Hercules: The AQM WE2E test has successfully passed on Hercules: |
Collaborator
|
The Coverage WE2E tests successfully passed on Derecho: The UFS Fire WE2E tests successfully passed on Derecho: The AQM WE2E test successfully passed on Derecho: |
MichaelLueken
approved these changes
Mar 19, 2026
Collaborator
MichaelLueken
left a comment
MichaelLueken
left a comment
There was a problem hiding this comment.
Thanks for updating to the weather model and applying the necessary modifications to exercise the new CFBM capabilities in the SRW, @mkavulich.
These changes look good to me and the testing has successfully completed.
Approving PR now.
RatkoVasic-NOAA
approved these changes
Mar 19, 2026
Collaborator
RatkoVasic-NOAA
left a comment
RatkoVasic-NOAA
left a comment
There was a problem hiding this comment.
Ursa:
----------------------------------------------------------------------------------------------------
Experiment name | Status | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_RRFS_lbcs_RRFS_suite_RRFS_sas_202 COMPLETE 16.54
custom_ESGgrid_Central_Asia_3km_20260319185956 COMPLETE 48.71
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot COMPLETE 19.84
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2026031 COMPLETE 50.74
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20260319190 COMPLETE 23.09
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2026031919005 COMPLETE 35.88
----------------------------------------------------------------------------------------------------
Total COMPLETE 194.80
Orion:
----------------------------------------------------------------------------------------------------
Experiment name | Status | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_RRFS_lbcs_RRFS_suite_RRFS_sas_202 COMPLETE 19.91
custom_ESGgrid_Central_Asia_3km_20260319141650 COMPLETE 100.86
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot COMPLETE 24.98
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2026031 COMPLETE 60.75
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20260319141 COMPLETE 34.08
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2026031914190 COMPLETE 45.49
----------------------------------------------------------------------------------------------------
Total COMPLETE 286.07
Hercules:
----------------------------------------------------------------------------------------------------
Experiment name | Status | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_RRFS_lbcs_RRFS_suite_RRFS_sas_202 COMPLETE 11.01
custom_ESGgrid_Central_Asia_3km_20260319141319 COMPLETE 54.25
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot COMPLETE 13.68
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2026031 COMPLETE 30.64
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20260319141 COMPLETE 24.93
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2026031914143 COMPLETE 23.72
----------------------------------------------------------------------------------------------------
Total COMPLETE 158.23
Approving.
MichaelLueken
added
the
run_we2e_coverage_tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
This PR brings in a new set of changes to the CFBM (fire_behavior) fire simulation capability. This introduces two new options available in the
fire:section ofconfig.yaml:WIND_VINTERP_OPTis a new namelist option for the fire behavior model. The default0uses the 3d wind field from the weather model to affect fire spread -- this is identical to the previous behavior. The new optionWIND_VINTERP_OPT: 1instead uses the diagnostic 10m wind speed to affect fire spread.OMP_NUM_THREADS_FIREallows for OpenMP parallelism in the fire code. The code is now by default compiled with the OPENMP parallelism option, though the defaultOMP_NUM_THREADS_FIRE: 1mirrors previous behavior, using only one tile/thread for the fire behavior model. In testing we found significant (~25%) speedup withOMP_NUM_THREADS_FIRE: 2for the WE2E test domain, and minimal speedup with larger numbers of parallel processes. However, If users have a larger custom domain, more threads may show further speedup.Type of change
TESTS CONDUCTED:
Ran
fundamentalandfiresets of tests on Orion (with fire model compiled,-a=ATMF); all passed. Ran fundamental test on Derecho without fire compilation, all pass. The integration test for the fire cases was updated to account for the new namelist options.DEPENDENCIES:
DOCUMENTATION:
The FIRE chapter of the users guide was updated for the new options.
ISSUE:
Resolves #1366
CHECKLIST
CONTRIBUTORS:
The work introducing these capabilities to the ufs weather model and its submodules was done by @masih-e, updates to the CFBM were made by @pedro-jm and @masih-e