Fixes to the documentation#123
Conversation
|
There is one more fix that I think @jwolff-ncar would like in the graphics chapter, which is how to specify CDATE. Using
(see end of that chapter) happens to work if you're running just one cycle, but in general it won't. I don't have time to fix this today. Up to you all if you want to merge this today or wait until tomorrow afternoon for a fix (or someone else just make a new PR for that fix). |
jwolff-ncar
left a comment
There was a problem hiding this comment.
I would prefer to leave CDATE defined as is in the batch script. These scripts will not work for multiple cycles as is so no need to make it fancier at this point. (Plus, NO MORE code changes!) If someone runs multiple cycles they will need to hard code the CDATE for the cycle they want to visualize. What we should do instead is add the following (in bold below) to the documentation at the end of the graphics chapter:
"In addition, the following variables can be modified in the batch scripts depending on your needs (for example, if you have run multiple cycles and you want to plot output from a cycle other than the very first one, CDATE may be set to YYYYMMDDHH; if you want to plot hourly forecast output, FCST_INC should be set to 1; if you just want to plot a subset of your model output, you can set FCST_START, FCST_END, and FCST_INC accordingly):
|
One more request. Please add the following to the graphics chapter (in bold below). "... |
|
I have not assessed the WE2E test chapter changes. I am Hopeful someone else can read through that and provide comments if needed. |
My plan is to read through the entire documentation on the weekend and note whatever differs from the testing I have done so far and will do tomorrow. |
|
I've addressed all the requested changes. Just need an approval to merge. |
…nce previously there was only one section); change "Tier 1" to "Level 1".
|
Content looks good. I did not check the formatting so that should be done once it has been merged if Gerard was not able to get that working on his machine. |
Fortunately, I was able to get sphinx to work on my laptop and checked the content. Looked good, but always appreciate someone else looking it over. Will merge now. |
rrfs_ci: Merge in develop
DESCRIPTION OF CHANGES:
TESTS CONDUCTED:
None.