Add CMEPS to ufs-s2s-model#90
Merged
DeniseWorthen merged 152 commits intoJun 3, 2020
Merged
Conversation
Feature/add comparisons (#4)
merge develop/ufs-s2s-model
MOM_input template for initial condition files
merge fv3atm/develop
This reverts commit 0c8cb0b.
add appbuilder files for CMEPS
cmeps nems.configure
merge to latest develop
Debug mode capablility (#15)
Add debug compilation flag specification at top level (#17)
update to current ufs-weather-app (#19)
after updating to current ufs-s2s@develop No changes to answers are expected Tests fail only because of the global attribute in MOM6 MOM6 restart files
create it using the date strings; add fixes for restart test
in med_modelio.nml. add cmeps 6h debug test w/ 1hour wall clock
Orion post maintenance fix (ufs-community#102)
run file to setup C96 restart test
Collaborator
Author
|
Regression tests are currently running on Hera. |
DeniseWorthen
requested review from
JessicaMeixner-NOAA,
MinsukJi-NOAA,
binli2337 and
junwang-noaa
Collaborator
JessicaMeixner-NOAA
left a comment
JessicaMeixner-NOAA
left a comment
There was a problem hiding this comment.
Just a few comments/questions, but overall looks good to me. I'll hit the approve after the regtests all go through.
only used by CIME driver. Add ifdef CMEPS to fv3_coupled for all platforms. Re-order rt.conf so that when executed sequentially, all cold jobs are done first. For restart test, set up to copy restarts from the 'dependent run' directory.
Reran tests w/ changes to nems.configure and adding DEP_RUN variable (currently manually set) in restart test
JessicaMeixner-NOAA
approved these changes
Jun 3, 2020
Collaborator
JessicaMeixner-NOAA
left a comment
JessicaMeixner-NOAA
left a comment
There was a problem hiding this comment.
This is great!
junwang-noaa
approved these changes
Jun 3, 2020
Collaborator
junwang-noaa
left a comment
junwang-noaa
left a comment
There was a problem hiding this comment.
Thanks for making changes in restart test. Please remove the tests/output, it seems a temporary file to me.
We may need to discuss on how to start the model later.
Collaborator
Author
|
Thanks Everyone for your timely reviews. |
DeniseWorthen
added a commit
to DeniseWorthen/ufs-s2s-model
that referenced
this pull request
Jun 5, 2020
Add CMEPS to ufs-s2s-model (ufs-community#90)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a second mediator ( CMEPS ) to the ufs-s2s-model:
Adds CMEPS version regression tests for all current NEMS mediator tests (rt.sh). All current NEMS mediator baselines were tested and found identical except for a global attribute difference in the MOM6 restarts (commit 45f515e in this branch).
Adds a restart reproducibility test for CMEPS. A 3 day C96 baseline is created. The 2d C96 is restarted and run for an additional day. Answers are then compared against the 3 day baseline. An rt.conf.restart file is added for convenience since no baseline is created for the restart test.
Updates namelists and nems.configure files for the coupled model to accommodate warm-start restarting of the coupled model
Updates the namelist settings for the restart output directory for MOM6 from MOM6_RESTART to RESTART and the output directory for CICE5 from restart to RESTART. Both are consistent with FV3
Adds two additional configurable settings to MOM_input_template. Default values are consistent with current settings used in ufs-s2s-model. Restart reproducibility requires non-default values until the halo decomposition bug seen when USE_LA_LI2016 = true is fixed.
Updates NEMS to the current develop which contains a fix for CMEPS build for rt.sh and also adds required component.mk for CICE6.
This PR will become active after the associated CICE5 PR: #89
Associated project: 2
Associated issues: #48, #32, #33, #76
Co-author: @mvertens
The following figures show the difference in the ocean surface state and the ice surface state after 10d for a single initial condition date for the NEMS and CMEPS mediators.
The following figures show the difference in the ocean surface state after 10d for a single initial condition date when wave coupling is included.