Update FV3, NEMS#21
Merged
DeniseWorthen merged 23 commits intoJan 28, 2020
Merged
Conversation
Feature/add comparisons (#4)
merge develop/ufs-s2s-model
MOM_input template for initial condition files
merge fv3atm/develop
This reverts commit 0c8cb0b.
merge to latest develop
Debug mode capablility (#15)
Add debug compilation flag specification at top level (#17)
update to current ufs-weather-app (#19)
nomerg2atm, new MOM6 dev/emc
Collaborator
|
Can we point to "master-20200128" on the wcoss.input even though the baselines aren't there (yet)? My only other comment is if possible put more detail in the commit message when you merge so we don't have to go to the issue to see the details of what the updates were since this was a big update for fv3 and NEMS. --- and to add that this update for MOM6 did not change answers but added the variable to the restart file. |
Collaborator
Author
|
Yes, thanks. I've updated wcoss.input and will include details of the recent FV3, NEMS and MOM6 commit when I merge. |
JessicaMeixner-NOAA
approved these changes
Jan 28, 2020
binli2337
approved these changes
Jan 28, 2020
Collaborator
binli2337
left a comment
binli2337
left a comment
There was a problem hiding this comment.
Looks good to me. Please prepare a detailed merge message.
Collaborator
|
Denise,
I want to confirm that you have the latest FV3 revision and the NEMS commit
with the unmerged field. So after this merge the code is ready for
prototype 3.1. Thanks.
Jun
…On Tue, Jan 28, 2020 at 10:07 AM BinLi-NOAA ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good to me. Please prepare a detailed merge message.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#21?email_source=notifications&email_token=AI7D6TIFVGCPEPMNHAOZ7FDRABC25A5CNFSM4KMKVUGKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCTKCSJI#pullrequestreview-349448485>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TMUXDVL6DMO6EUC5BLRABC25ANCNFSM4KMKVUGA>
.
|
Collaborator
Author
|
Yes Jun, we are now up-to-date with FV3 and the NEMS change with the un-merged fields in prep_atm. Thanks. |
DeniseWorthen
referenced
this pull request
in DeniseWorthen/ufs-s2s-model
Jan 28, 2020
Update FV3, NEMS (#21)
JessicaMeixner-NOAA
pushed a commit
to JessicaMeixner-NOAA/ufs-s2s-model
that referenced
this pull request
Feb 3, 2020
FV3 is updated to include the following: * fv3atm issue ufs-community#37: fix the real(8) lat/lon in netcdf file * fv3atm ufs-community#35: Reducing background vertical diffusivities in the inversion layers * fv3atm ufs-community#24: bug in gfsphysics/physics/moninedmf_hafs.f * fv3atm ufs-community#18: Optimize netcdf write component and bugfix for post and samfdeepcnv.f * set (0-1) bounds for ficein_cpl * remove cache_size due to lower netcdf verion 4.5.1 on mars * Change ice falling to 0.9 in gfsphysics/physics/gfdl_cloud_microphys.F90 NEMS is updated to remove ice-ocean merge in prep_atm: * The following fields are now exported to FV3 as ice-only fields: mean_sensi_heat_flx mean_laten_heat_flx mean_up_lw_flx mean_evap_rate mean_zonal_moment_flx mean_merid_moment_flx MOM6 is updated to GFDL's 20200108 dev/master: * MOM6 adds field in MOM.res_1.nc (kg_m3_to_R). All other files are reproducible with previous baseline
JessicaMeixner-NOAA
pushed a commit
to JessicaMeixner-NOAA/ufs-s2s-model
that referenced
this pull request
Apr 23, 2020
ShanSunNOAA
pushed a commit
to ShanSunNOAA/ufs-s2s-model
that referenced
this pull request
Oct 28, 2020
Number concentration bug and code clean up in ccpp-physics GFS_suite_interstitial_4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #20
New baseline is added for Hera; logs are committed