update to current ufs-weather-app#19
Merged
DeniseWorthen merged 28 commits intoJan 24, 2020
Merged
Conversation
Feature/add comparisons (#4)
merge develop/ufs-s2s-model
MOM_input template for initial condition files
merge fv3atm/develop
This reverts commit 0c8cb0b.
merge to latest develop
Debug mode capablility (#15)
Add debug compilation flag specification at top level (#17)
Add back -link_mpi=dbg lost in merge
add back -link_mpi=dbg lost in merge
Collaborator
|
Denise,
Just would like to let you know that your pull request #39 will be
committed soon, you may want to include that in your commit, otherwise
there will still be seg fault problem in coupled model. Thanks.
Jun
…On Thu, Jan 23, 2020 at 9:42 AM Denise Worthen ***@***.***> wrote:
Updates FV3,FMS and stochastic_physics submodules to match current
ufs-weather model (b41e023) from 01-10-2020.
Updates conf,modulefiles,parm and compsets.
------------------------------
You can view, comment on, or merge this pull request online at:
#19
Commit Summary
- Merge pull request #1 from ufs-community/develop
- Update .gitmodules
- update submodules for nems,stochastic_physics
- update NEMS,stochastic_physics
- Merge pull request #2 from ufs-community/develop
- update CICE submode for feature/halfdeg (with build change) and
- Merge pull request #3 from ufs-community/develop
- Revert "update CICE submode for feature/halfdeg (with build change)
and"
- update CICE submodule
- update develop branch in my fork to use NOAA-EMC develop branches
- Merge pull request #5 from ufs-community/develop
- Merge pull request #6 from ufs-community/develop
- Update configure.fv3_coupled.hera.intel
- Update configure.fv3_coupled.cheyenne.intel
- update conf,parm and modulefiles to current ufs-weather-model
- Merge pull request #7 from ufs-community/develop
- Merge branch 'develop' into feature/up2ufs_weather
- Update configure.fv3_coupled.cheyenne.intel
- Update configure.fv3_coupled.hera.intel
- add hera logs
- add hera logs
- update FV3
- update stochastic_physics submodule
- update FMS to tag 2019.01 from GFDL repo
- add hera logs; all tests pass
File Changes
- *M* .gitmodules
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-0>
(4)
- *M* FMS
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-1>
(2)
- *M* FV3
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-2>
(2)
- *M* compsets/fv3.input
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-3>
(3)
- *M* conf/configure.fv3.wcoss_phase2
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-4>
(2)
- *M* conf/configure.fv3_coupled.wcoss_phase2
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-5>
(2)
- *M* log/report-hera.intel-log/build_fv3_mom6_cice.exe.log
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-6>
(2425)
- *M* log/report-hera.intel-log/rtreport.txt
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-7>
(73)
- *M* modulefiles/cheyenne.intel/fv3
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-8>
(8)
- *M* modulefiles/gaea.intel/fv3
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-9>
(10)
- *M* modulefiles/gaea.intel/fv3_coupled
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-10>
(2)
- *M* modulefiles/hera.intel/fv3
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-11>
(15)
- *M* modulefiles/hera.intel/fv3_coupled
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-12>
(4)
- *M* modulefiles/jet.intel/fv3
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-13>
(8)
- *M* modulefiles/wcoss_cray/fv3
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-14>
(13)
- *M* modulefiles/wcoss_cray/fv3_coupled
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-15>
(4)
- *M* modulefiles/wcoss_dell_p3/fv3
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-16>
(13)
- *M* modulefiles/wcoss_dell_p3/fv3_coupled
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-17>
(4)
- *M* modulefiles/wcoss_phase2/fv3
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-18>
(4)
- *M* modulefiles/wcoss_phase2/fv3_coupled
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-19>
(4)
- *M* parm/ccpp_control.nml.IN
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-20>
(2)
- *M* parm/ccpp_gfdlmp.nml.IN
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-21>
(2)
- *M* parm/gfdlmp.nml.IN
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-22>
(4)
- *M* parm/input.mom6.nml.IN
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-23>
(6)
- *M* parm/input.nml.IN
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-24>
(6)
- *M* stochastic_physics
<https://github.com/ufs-community/ufs-s2s-model/pull/19/files#diff-25>
(2)
Patch Links:
- https://github.com/ufs-community/ufs-s2s-model/pull/19.patch
- https://github.com/ufs-community/ufs-s2s-model/pull/19.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#19?email_source=notifications&email_token=AI7D6TKIODPRZ7Y72N2DKT3Q7GUG7A5CNFSM4KKXSCF2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IIIOBCA>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TLXTHZS32CQSBOLZ4LQ7GUG7ANCNFSM4KKXSCFQ>
.
|
Collaborator
|
The build on WCOSS-phase2 failed: code location: /marine/noscrub/Jessica.Meixner/ufs-s2s-model |
Collaborator
|
The code is not expected to run on phase2 as the new version of FMS does
not work with available intel versions on phase2. There is no way to update
intel version as the machine is going to be gone soon. ufs-weather-model
drops phase1/2 support after the commit with FMS update.
…On Thu, Jan 23, 2020 at 1:30 PM Jessica Meixner ***@***.***> wrote:
The build on WCOSS-phase2 failed:
od_mp_get_peset_':
/gpfs/td1/emc/marine/noscrub/Jessica.Meixner/ufs-s2s-model/FMS/fv3gfs/../mpp/include/mpp_util_mpi.inc:128: undefined reference to `mpi_comm_create_group_'
make[1]: *** [nems] Error 1
make[1]: Leaving directory `/gpfs/td1/emc/marine/noscrub/Jessica.Meixner/ufs-s2s-model/NEMS/src'
make: *** [/gpfs/td1/emc/marine/noscrub/Jessica.Meixner/ufs-s2s-model/NEMS/exe/NEMS.x] Error 2
*code location*: /marine/noscrub/Jessica.Meixner/ufs-s2s-model
*build log*:
/ptmpp2/Jessica.Meixner/rtgen.12307/tmp/log/build_fv3_mom6_cice.exe.log
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#19?email_source=notifications&email_token=AI7D6TPEM5MXSRA2ICFITWLQ7HO3TA5CNFSM4KKXSCF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJYLPVA#issuecomment-577812436>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TPGPZX4EWR6Q3BC6TTQ7HO3TANCNFSM4KKXSCFQ>
.
|
Collaborator
|
Thanks @junwang-noaa I had forgotten about that. We need to temporarily keep the old FMS then, because we want to run the prototype 3.1 on wcoss-phase2. |
Collaborator
Author
|
Thanks Jun. I had forgotten about this.
I was getting concerned that we were more than 2 commits behind on FV3. I
feel this has led to trouble in the past when we don't keep up with and
test FV3 commits.
…On Thu, Jan 23, 2020 at 1:40 PM Jessica Meixner ***@***.***> wrote:
Thanks @junwang-noaa <https://github.com/junwang-noaa> I had forgotten
about that. We need to temporarily keep the old FMS then, because we want
to run the prototype 3.1 on wcoss-phase2.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19?email_source=notifications&email_token=AJU7JZG6AA2SNDHLURJU34DQ7HQB5A5CNFSM4KKXSCF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJYMPZA#issuecomment-577816548>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJU7JZFDQDEYH2GMZZAGJ73Q7HQB5ANCNFSM4KKXSCFQ>
.
--
Denise Worthen
IMSG at NOAA/NWS/NCEP/EMC
Denise.Worthen@noaa.gov
|
Collaborator
Author
|
With FMS reverted to GFS-FMS branch, both hera and wcoss-phase2 pass regression tests. With this commit, we are up-to-date with fv3atm. Users should proceed with caution until the the next commit of FV3 is made, which will contain the stability fix for the coupled model (limit ice fraction to [0-1]. |
JessicaMeixner-NOAA
approved these changes
Jan 24, 2020
binli2337
approved these changes
Jan 24, 2020
Collaborator
binli2337
left a comment
binli2337
left a comment
There was a problem hiding this comment.
I have reviewed the changes.
DeniseWorthen
referenced
this pull request
in DeniseWorthen/ufs-s2s-model
Jan 24, 2020
update to current ufs-weather-app (#19)
Collaborator
|
Denise,
Just let you know that your pull request #39 "place min/max values on
imported ice_fraction" is scheduled to be committed today as shown in
google sheet. So you may want to update the code again. Thanks
Jun
…On Fri, Jan 24, 2020 at 11:26 AM Denise Worthen ***@***.***> wrote:
Merged #19 <#19> into
develop.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19?email_source=notifications&email_token=AI7D6TJLQHDLSYS6HD2YO4DQ7MJCPA5CNFSM4KKXSCF2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWF67YBQ#event-2977823750>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TJGTCEYOC333RTLFNLQ7MJCPANCNFSM4KKXSCFQ>
.
|
Collaborator
Author
|
Yes, thanks. I also have a draft PR on NEMS for the un-merging of fields between ocean and ice in prep_atm. We will need a new baseline to be created for the updated fv3 and the nems. |
Collaborator
|
Denise,
So your next commit is the unmerged field in NEMS, then the s2s model will
have both fv3 and NEMS change, and that will become your bench mark 3.1.
Meanwhile, just let you know there will be another commit for GFSv16
underway, which currently does not have any impact on the results for s2s.
And the ufs-weather-model will point to the updated NEMS develop. Thanks.
…On Fri, Jan 24, 2020 at 11:58 AM Denise Worthen ***@***.***> wrote:
Yes, thanks. I also have a draft PR on NEMS for the un-merging of fields
between ocean and ice in prep_atm. We will need a new baseline to be
created for the updated fv3 and the nems.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19?email_source=notifications&email_token=AI7D6TIIUQTSUDITYUQQ76DQ7MMZTA5CNFSM4KKXSCF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ3NMQQ#issuecomment-578213442>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TNFTCG72INJ4DBRYJDQ7MMZTANCNFSM4KKXSCFQ>
.
|
JessicaMeixner-NOAA
pushed a commit
to JessicaMeixner-NOAA/ufs-s2s-model
that referenced
this pull request
Feb 3, 2020
Updates FV3 and stochastic_physics submodules to match current ufs-weather model (b41e023) from 01-10-2020. Updates conf,modulefiles,parm and compsets.
JessicaMeixner-NOAA
pushed a commit
to JessicaMeixner-NOAA/ufs-s2s-model
that referenced
this pull request
Apr 23, 2020
Add CCPP to UFS-S2S-model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates FV3,FMS and stochastic_physics submodules to match current ufs-weather model (b41e023) from 01-10-2020.
Updates conf,modulefiles,parm and compsets.