Skip to content

Enable rt.sh dependency relations#112

Merged
DeniseWorthen merged 6 commits into
ufs-community:developfrom
MinsukJi-NOAA:feature/rt-dependency
Jun 25, 2020
Merged

Enable rt.sh dependency relations#112
DeniseWorthen merged 6 commits into
ufs-community:developfrom
MinsukJi-NOAA:feature/rt-dependency

Conversation

@MinsukJi-NOAA
Copy link
Copy Markdown
Collaborator

Issue #103
*Used to create baselines in one step without manual copying of files
*Used for restart rt to get initial data from work directory
*Merge cpld_fv3_mom6_cice_atm_flux_restart_run.IN into cpld_fv3_mom6_cice_atm_flux_run.IN

*Used to create baselines in one step without manual copying of files
*Used for restart rt to get initial data from work directory
*Merge cpld_fv3_mom6_cice_atm_flux_restart_run.IN into cpld_fv3_mom6_cice_atm_flux_run.IN
@MinsukJi-NOAA MinsukJi-NOAA marked this pull request as ready for review June 18, 2020 14:21
@DeniseWorthen
Copy link
Copy Markdown
Collaborator

So looking through the tests, it seems like for now we're not implementing the restart test to use the intermediate restarts. Is the plan is first to implement the dependency function and then later move to using the intermediate restarts? At that point, the 3d run tests could be deleted.

@MinsukJi-NOAA
Copy link
Copy Markdown
Collaborator Author

That's right. The restart run in this PR stays mostly the same as before. The only change is that it is grabbing the restart data from a current run (not the baseline data) whose name is specified as a dependency in rt.conf.

Copy link
Copy Markdown
Collaborator

@DeniseWorthen DeniseWorthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the changes in test/fv3_conf, tests/tests and rt.conf and they look right.

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

Is there any reason why the dependency would not work with the 35d optional tests that Bin added?

@MinsukJi-NOAA
Copy link
Copy Markdown
Collaborator Author

I did not look into the 35d tests. Looks like we just need to add the dependencies in the 6th column of rt_35d_*.conf files.

Comment thread tests/fv3_conf/fv3_slurm.IN
@DeniseWorthen
Copy link
Copy Markdown
Collaborator

I ran into a problem trying to run the 35d test w/ the dependency on orion. I got
cp: cannot stat '/work/noaa/stmp/jminsuk/RT/FV3-MOM6-CICE5/develop-20200530/WW3_input_data/ww3_multi_35d.inp': No such file or directory

@binli2337 Is there additional input required in the baseline for the 35d test

@MinsukJi-NOAA
Copy link
Copy Markdown
Collaborator Author

Which test case was that?

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

DeniseWorthen commented Jun 19, 2020

I tried the rt_35d_cmeps.conf after you added the dependency columns. I merged your rt-dependency branch to my develop branch.

@MinsukJi-NOAA
Copy link
Copy Markdown
Collaborator Author

MinsukJi-NOAA commented Jun 19, 2020

I am running rt_35d_cmeps.conf on Orion right now.

@MinsukJi-NOAA
Copy link
Copy Markdown
Collaborator Author

Dependency implementations in this PR actually does not affect the 35 day runs, because we are neither generating the baselines nor testing the restart capability. Nevertheless, the 35d cmeps cold run were completed successfully. Warm runs did not complete because of the issue here: #111 (comment)

@MinsukJi-NOAA
Copy link
Copy Markdown
Collaborator Author

This PR is ready for merge. Other 35-day run issues should be addressed separately.

@DeniseWorthen DeniseWorthen merged commit b311bc2 into ufs-community:develop Jun 25, 2020
@MinsukJi-NOAA MinsukJi-NOAA deleted the feature/rt-dependency branch June 25, 2020 15:19
DeniseWorthen added a commit to DeniseWorthen/ufs-s2s-model that referenced this pull request Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants