[develop] Update scripts to run with the latest hash of ufs weather model#796
Merged
chan-hoo merged 3 commits intoJun 23, 2022
Conversation
chan-hoo
requested review from
BenjaminBlake-NOAA,
EdwardSnyder-NOAA,
JeffBeck-NOAA,
RatkoVasic-NOAA,
christinaholtNOAA,
christopherwharrop-noaa,
danielabdi-noaa,
dmwright526,
gsketefian,
gspetro-NOAA,
jkbk2004,
mark-a-potts,
mkavulich,
natalie-perlin,
panll,
willmayfield and
ywangwof
as code owners
chan-hoo
added
Tested on Hera
RatkoVasic-NOAA
approved these changes
Jun 15, 2022
Collaborator
RatkoVasic-NOAA
left a comment
RatkoVasic-NOAA
left a comment
There was a problem hiding this comment.
Looks good to me
christopherwharrop-noaa
approved these changes
Jun 15, 2022
Collaborator
christopherwharrop-noaa
left a comment
christopherwharrop-noaa
left a comment
There was a problem hiding this comment.
I'm not qualified to evaluate the validity of the science/options changes, so I leave that to others. The code style/quality looks good, and tests were run, so I don't see any issues.
danielabdi-noaa
approved these changes
Jun 15, 2022
Collaborator
danielabdi-noaa
left a comment
danielabdi-noaa
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for updating python scripts.
Collaborator
Author
|
@christopherwharrop-noaa, I believe that this is the first time I have gotten your approval without any change requests! Hooray!!! :) :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
TESTS CONDUCTED:
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp_regional
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson_mynn_lam3km
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_RRFS_v1beta
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1alpha
DEPENDENCIES: