Add NOAA cloud platforms to SRW#689
Merged
Merged
Conversation
mark-a-potts
requested review from
BenjaminBlake-NOAA,
JeffBeck-NOAA,
RatkoVasic-NOAA,
chan-hoo,
christinaholtNOAA,
christopherwharrop-noaa,
danielabdi-noaa,
gsketefian,
jkbk2004,
mkavulich,
panll and
ywangwof
as code owners
mark-a-potts
requested review from
dmwright526,
jwolff-ncar and
willmayfield
as code owners
JeffBeck-NOAA
approved these changes
Mar 7, 2022
christinaholtNOAA
suggested changes
Mar 7, 2022
Contributor
christinaholtNOAA
left a comment
christinaholtNOAA
left a comment
There was a problem hiding this comment.
@mark-a-potts Thanks for adding the files and example on how this is done! My apologies for using your PRs as a "big picture" question forum.
Reviewers -- please see my comments in the corresponding SRW PR about how we might best support new platforms.
christinaholtNOAA
approved these changes
Mar 7, 2022
Contributor
christinaholtNOAA
left a comment
christinaholtNOAA
left a comment
There was a problem hiding this comment.
After our conversation in the EPIC Sprint Review this morning, I am less concerned about this not being a traditionally "supported" platform. Just one quick requested change from me.
gsketefian
added a commit
that referenced
this pull request
Mar 8, 2022
## DESCRIPTION OF CHANGES: Cleaning up bugs in the machine files. The first bug prompted this PR, and the rest were found subsequently. The bugs (and their fixes) are as follows: 1) A space is missing after the `print_info_msg` and `print_err_msg_exit` function calls in the `file_location` functions. Inserting a space gets passed this bug, but subsequent issues were found as described below. **For machine files that call the `print_info_msg` function in `file_location` (`cheyenne.sh`, `hera.sh`, `jet.sh`, and `orion.sh`):** Fixing this bug leads to other failures because when the "*" stanza is encountered in the `file_location` function, the `EXTRN_MDL_SYSBASEDIR_ICS|LBCS` variable gets set to the message that `file_location` returns. Since that message contains spaces, it leads to other failures in downstream scripts (the ex-scripts). Simply removing the printing out of the message (thus causing `EXTRN_MDL_SYSBASEDIR_ICS|LBCS` to be set to a null string) fixes the failures, so this was the fix implemented. If desired, a message for an empty value for `EXTRN_MDL_SYSBASEDIR_ICS|LBCS` can be placed in another script (where those variables are used). **For machine files that use `print_err_msg_exit` in `file_location` (`stampede.sh` and `wcoss_dell_p3.sh`):** These should not exit if the file location is not available since the experiment can still complete successfully. So just removing the `print_err_msg_exit` call should work (and make the behavior of these machine files consistent with the set above). 2) In all the machine files, the variable `FV3GFS_FILE_FMT_ICS` should be changed to `FV3GFS_FILE_FMT_LBCS` in the definition of `EXTRN_MDL_SYSBASEDIR_LBCS`. This was fixed in all the files. 3) In `stampede.sh`, a variable named `SYSBASEDIR_ICS` is defined. This is a typo. Modify to `EXTRN_MDL_SYSBASEDIR_ICS`. ## TESTS CONDUCTED: Ran the WE2E test `grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_GSD_SAR` on: * Hera -- successful * Jet -- successful except for UPP tasks * Cheyenne -- successful except for UPP tasks The UPP task failures are new and being experienced by other PRs as well (e.g. #689). The original issue with machine files seems resolved. ## CONTRIBUTORS (optional): @JeffBeck-NOAA encountered and reported the original error.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Adds all three NOAA cloud platforms to the SRW application with both Intel and GCC compilers pre-configured.
TESTS CONDUCTED:
The full workflow based on a modified GST has been successfully completed using Intel compilers on both AWS and Azure platforms.
The full workflow currently fails when using GNU compilers due to a bug in (most likely) the UPP.
DEPENDENCIES:
None
DOCUMENTATION:
WIP