Add ulimit to the task scripts for Orion#626
Conversation
chan-hoo
requested review from
BenjaminBlake-NOAA,
JeffBeck-NOAA,
gsketefian and
mkavulich
as code owners
| "HERA") | ||
| ulimit -s unlimited | ||
| ulimit -a | ||
| APRUN="time" |
There was a problem hiding this comment.
@chan-hoo, did you mean to add these to the Hera block too? I see you tested on Hera, but just wanted to make sure. The title and description of changes for the PR doesn't mention Hera. You can change that if it's appropriate.
There was a problem hiding this comment.
Also, I see you said this change was necessary to resolve a memory limit. I've never run into a memory limit error on Orion or Hera using the domains you tested. Is this a relatively recent error that you didn't have before? Do you think Jet needs a "ulimit -s unlimited" line as well?
There was a problem hiding this comment.
@JeffBeck-NOAA, I didn't have any issues on Hera. I'll remove this change for Hera. Regarding Orion, yes, I didn't have this error a couple of months ago either, but I got this when I tested the 3km domains on Orion last week. I don't think Jet needs this change.
| "HERA") | ||
| ulimit -s unlimited | ||
| ulimit -a | ||
| APRUN="time" |
There was a problem hiding this comment.
Also, I see you said this change was necessary to resolve a memory limit. I've never run into a memory limit error on Orion or Hera using the domains you tested. Is this a relatively recent error that you didn't have before? Do you think Jet needs a "ulimit -s unlimited" line as well?
| @@ -105,6 +105,7 @@ case "$MACHINE" in | |||
|
|
|||
There was a problem hiding this comment.
No "ulimit -a" line necessary for the Hera block here?
There was a problem hiding this comment.
Hera doesn't need this change at this moment.
| @@ -125,6 +125,8 @@ case "$MACHINE" in | |||
| ;; | |||
There was a problem hiding this comment.
No modifications required to Hera here?
2 participants
DESCRIPTION OF CHANGES:
To resolve the memory issue, 'ulimit' is added to the 'make_grid', 'make_ics', and 'run_post' scripts for Orion.
TESTS CONDUCTED:
WE2E tests on Orion and Hera:
ISSUE:
Fixes issue mentioned in #625