Allow FVCOM to be used in Warm and Cold Starts#620
Merged
JeffBeck-NOAA merged 4 commits intoOct 27, 2021
Conversation
JeffBeck-NOAA
approved these changes
Oct 27, 2021
Collaborator
|
@dmwright526, I tested this PR with a cold start case using an FVCOM data set, and ran a second test with FVCOM="False". Results are as expected for each. Will merge now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Updates to the fvcom tools now require the use of two additional input variables:
One additional variable has been created for the config file (fvcom_wcstart) to define if the run will be a "warm" start or "cold" start. The creation of the time string is done in the exregional_make_ics.sh script and uses existing user defined variables (DATE_FIRST_CYCL, CYCL_HRS) to complete the task.
This will solve issue: https://github.com/NOAA-EMC/regional_workflow/issues/619
TESTS CONDUCTED:
Tests were performed on Hera and Jet for the RRFS NA grid and a custom grid over the Great Lakes.
DEPENDENCIES:
These changes are dependent upon ufs-community/UFS_UTILS#595.
DOCUMENTATION: