Fix unbound SED for cron commands in the launch script#606
Conversation
|
@chan-hoo I think the fix you're implementing will cause the workflow to break on MACOS. We should define This is the same approach as, for example, in |
|
@gsketefian , modified as suggested and tested successfully. |
gsketefian
left a comment
There was a problem hiding this comment.
@chan-hoo Thanks for fixing. Can you also update the PR message before merging so it doesn't say "$SED" was changed to "sed" but instead that source_util_funcs.sh was sourced? Thanks.
|
Thanks for suggesting this change @gsketefian, I can confirm this is needed for the launch script to work on MacOS (though right now we do not test this since we run the stand-alone scripts there). I am not sure why the old code passed tests before (I guess the failure was in removing old crontab entries and I didn't notice?), but this fix looks good. |
DESCRIPTION OF CHANGES:
To fix the issue on the launch script when 'USE_CRON_TO_RELAUNCH'="TRUE", 'source_util_funcs.sh' is sourced in the script.
TESTS CONDUCTED:
WE2E tests on WCOSS_DELL_P3:
ISSUE:
Fixes issue mentioned in #605