Changes needed to run the regional workflow on WCOSS#310
Merged
BenjaminBlake-NOAA merged 2 commits intoOct 14, 2020
Merged
Conversation
BenjaminBlake-NOAA
requested review from
JeffBeck-NOAA,
JulieSchramm,
RatkoVasic-NOAA,
gsketefian and
mkavulich
|
|
||
| "WCOSS_C") | ||
| "WCOSS_CRAY") | ||
| # This could be wrong. Just a guess since I don't have access to this machine. |
Collaborator
There was a problem hiding this comment.
@BenjaminBlake-NOAA, feel free to take out this comment now that things are correctly defined for the WCOSS_CRAY. Thanks!
Collaborator
Author
There was a problem hiding this comment.
Good call, I missed that comment. I just removed it!
Collaborator
There was a problem hiding this comment.
Thanks! Approving PR now.
JeffBeck-NOAA
approved these changes
Oct 13, 2020
Collaborator
|
Hey @BenjaminBlake-NOAA, feel free to merge this at your leisure. We're having PR authors do the final 'squash and merge' from now on (as long as they have admin or write access). |
Collaborator
Author
|
@JeffBeck-NOAA Sounds good I'll do that now |
gsketefian
added a commit
that referenced
this pull request
Oct 15, 2020
Original PR #310 is by @BenjaminBlake-NOAA. * Changes needed to run the regional workflow on WCOSS * Update exregional_make_sfc_climo.sh Co-authored-by: Benjamin.Blake EMC <Benjamin.Blake@m71a2.ncep.noaa.gov>
christinaholtNOAA
pushed a commit
to christinaholtNOAA/regional_workflow
that referenced
this pull request
Apr 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
This pull request contains changes that are needed for running the latest version of the regional workflow on WCOSS. It involves modifications to the make_grid, make_orog, and make_sfc_climo ex-scripts, and setup.sh. There are some additional modifications required to the xml template and modulefiles, but we can discuss how to best handle those changes at a later date. This PR needs to be tested concurrently with PR #31 of ufs-srweather-app.
TESTS CONDUCTED:
Successfully completed an end-to-end test on the WCOSS-Dell with these changes.
ISSUE (optional):
CONTRIBUTORS (optional):
Annette Gibbs was a huge help with running these tests on WCOSS.