Remove the USE_CCPP variable#308
Conversation
gsketefian
requested review from
BenjaminBlake-NOAA,
JeffBeck-NOAA,
JulieSchramm,
RatkoVasic-NOAA and
mkavulich
| check_var_valid_value \ | ||
| "CCPP_PHYS_SUITE" "valid_vals_CCPP_PHYS_SUITE" "${err_msg}" | ||
| # | ||
| #----------------------------------------------------------------------- |
There was a problem hiding this comment.
@gsketefian, This block of code (lines 553-578) is no longer necessary now that we can initialize from external model data with either 4 or 9 soil levels, and run with LSMs of either 4 or 9 soil levels. Can you remove it?
There was a problem hiding this comment.
@JeffBeck-NOAA Since this is not directly related to the USE_CCPP variable, I would like to do this in another PR. I'm planing on another PR that will remove outdated code that modifies LD_LIBRARY_PATH for FV3 and makes some fixes if using the FV3_GFS_2017_gfdlmp_regional suite that are no longer necessary. I will make this change as part of that PR; call it an overall "remove outdated code" PR. Sound ok?
|
Need an approval to merge this. |
RatkoVasic-NOAA
left a comment
RatkoVasic-NOAA
left a comment
There was a problem hiding this comment.
Looks OK to me.
|
@RatkoVasic-NOAA Thanks Ratko. I will merge now. |
3 participants
DESCRIPTION OF CHANGES:
This PR removes the USE_CCPP variable from all scripts and other files. The workflow only supports running the FV3 model with CCPP, so USE_CCPP is deprecated.
TESTS CONDUCTED:
Ran one WE2E test (regional_002) on hera. Succeeded.
ISSUE (optional):
This resolves Issue #196.