Skip to content

Improvements to WE2E testing system#296

Merged
gsketefian merged 4 commits into
ufs-community:developfrom
gsketefian:feature/WE2E_testing
Sep 18, 2020
Merged

Improvements to WE2E testing system#296
gsketefian merged 4 commits into
ufs-community:developfrom
gsketefian:feature/WE2E_testing

Conversation

@gsketefian
Copy link
Copy Markdown
Collaborator

This PR modifies the script that runs the WE2E tests (run_experiments.sh) as well as the individual WE2E configuration files to allow tests to run on hera and cheyenne without the need to manually change settings (e.g. directories) in the individual test configuration files. This capability can be easily extended to other platforms by adding appropriate stanzas in run_experiments.sh.

DESCRIPTION OF CHANGES:

  • Set the following workflow parameters in the run_experiments.sh script and write them to the workflow configuration file instead of having them defined in each WE2E configuration file (i.e. remove them from each WE2E configuration file):
    MACHINE, ACCOUNT, EXPT_SUBDIR, USE_CRON_TO_RELAUNCH, CRON_RELAUNCH_INTVL_MNTS, VERBOSE
    Note that all these parameters except EXPT_SUBDIR can now be set on the command line when calling run_experiments.sh. If they are not set on the command line, they get set to default values. Also, EXPT_SUBDIR always gets set to the name of the WE2E test.
  • Add new arguments stmp, ptmp, and verbose to run_experiments.sh so that users can specify them on the command line if they don't like the defaults.
  • In run_experiments.sh, source the default workflow configuration file (config_defaults.sh) to have all user-specifiable workflow variables defined in some way (even if some of those are set to nonsensical default values).
  • Put in a check to make sure the CCPP physics suite definition file exists in the ufs-weather-model repo.
  • Bug fix: Change default blending halo (HALO_BLEND) to 0 (no blending) to avoid bug in halo-blending PR. Bug is that the make_lbcs task does not create a blending zone (i.e. it assumes halo_blend is zero).

TESTS CONDUCTED:

Ran all WE2E tests except user_donwload_extrn_files on hera and cheyenne. All passed except regional_010, which has a preexisting bug related to FV3 namelist settings. Did not run user_donwload_extrn_files because it interrupts the progression of the test script (it needs improvements; but this PR does not affect downloading of external model files from NOMADS).

Note that on cheyenne, the make_ics, make_lbcs, and run_post tasks often have to be run multiple times before they succeed (especially the latter two).

* Set the following workflow parameters in the run_experiments.sh script and write them to the workflow configuration file instead of having them defined in each WE2E configuration file (i.e. remove them from each WE2E configuration file):
  MACHINE, ACCOUNT, EXPT_SUBDIR, USE_CRON_TO_RELAUNCH, CRON_RELAUNCH_INTVL_MNTS, VERBOSE
Note that all these parameters except EXPT_SUBDIR can now be set on the command line when calling run_experiments.sh.  If they are not set on the command line, they get set to default values.  Also, EXPT_SUBDIR always gets set to the name of the test.

* Add new arguments stmp, ptmp, and verbose to run_experiments.sh so that users can specify them on the command line if they don't like the defaults.

* In run_experiments.sh, source the default workflow configuration file (config_defaults.sh) to have all user-specifiable workflow variables
 defined in some way (even if some of those are set to nonsensical default values).
…efault blending halo (HALO_BLEND) to 0 (no blending) to avoid bug in halo-blending PR.
@gsketefian gsketefian merged commit 5acd351 into ufs-community:develop Sep 18, 2020
@gsketefian gsketefian deleted the feature/WE2E_testing branch September 18, 2020 20:42
christinaholtNOAA pushed a commit to christinaholtNOAA/regional_workflow that referenced this pull request Apr 27, 2022
…ion cycling: (ufs-community#296)

1) satellite radiance data assimilation could be turned on/off by "DO_RADDA" in the config files, the default is "FALSE" now.
2) satellite bias correction files are hourly cycled.  It is noted that usually, the full/partial cycle uses the bias coefficient files from its own previous cycle, but the 03z GSI from the partial cycle uses the bias correction coefficient files from the 02z full cycle and the 09z full cycle would use the bias correction coefficient files from the 08z from the partial cycles.  This is the similar case for the 15z partial cycle and the 21z full cycle.
3) satellite bias correction files are being saved under the $NWGES_BASEDIR/satbias/ directory
4) the script would look back up to 10 days for bias correction files, if not found under $NWGES_BASEDIR/satbias/, then it would use the satbias files under ${FIX_GSI}
5) adding some data sets (some for future usage) for "listall" for generating gsi diag files
6) adding rrfs satbias files to ${FIX_GSI} as backup satbias files to use/start
7) updating atms_beamwidth.txt file under ${FIX_GSI}.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants