Skip to content

Set ad-hoc stochastic physics scheme magnitudes to -999.0 when not used to avoid bug with do_sppt/skeb/shum namelist entries#291

Merged
JeffBeck-NOAA merged 12 commits into
ufs-community:developfrom
JeffBeck-NOAA:feature/adhoc_fix
Sep 15, 2020
Merged

Set ad-hoc stochastic physics scheme magnitudes to -999.0 when not used to avoid bug with do_sppt/skeb/shum namelist entries#291
JeffBeck-NOAA merged 12 commits into
ufs-community:developfrom
JeffBeck-NOAA:feature/adhoc_fix

Conversation

@JeffBeck-NOAA
Copy link
Copy Markdown
Collaborator

DESCRIPTION OF CHANGES:
Adds an "if" statement to the generate script to allow individual ad-hoc stochastic physics schemes to run without the others. If an ad-hoc scheme is not activated, its magnitude will be set to -999.0 to shut it off. Setting "do_shum/skeb/sppt" is insufficient unless all three schemes are "false," in which case nothing runs. If the model code is updated in the future to fix things, this PR can be reverted.

TESTS CONDUCTED:
Tested on Jet.

@JeffBeck-NOAA JeffBeck-NOAA changed the title Feature/adhoc fix Set ad-hoc stochastic physics scheme magnitudes to -999.0 when not used to avoid bug with do_sppt/skeb/shum namelist entries Sep 11, 2020
Comment thread ush/generate_FV3LAM_wflow.sh Outdated
@gsketefian
Copy link
Copy Markdown
Collaborator

gsketefian commented Sep 15, 2020 via email

@JeffBeck-NOAA
Copy link
Copy Markdown
Collaborator Author

JeffBeck-NOAA commented Sep 15, 2020 via email

…nd "FALSE" from lowercase to uppercase, and move the "if false, then -999.0" block from the generate to the setup script
@JeffBeck-NOAA
Copy link
Copy Markdown
Collaborator Author

@gsketefian, just added the commit referenced above.

@JeffBeck-NOAA JeffBeck-NOAA merged commit 55480b7 into ufs-community:develop Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants