Set ad-hoc stochastic physics scheme magnitudes to -999.0 when not used to avoid bug with do_sppt/skeb/shum namelist entries#291
Merged
JeffBeck-NOAA merged 12 commits intoSep 15, 2020
Conversation
…ed to avoid bug with do_sppt/skeb/shum namelist entries
gsketefian
reviewed
Sep 14, 2020
Collaborator
|
What's strange is I don't see this particular comment on the PR's
conversation page! Anyway, I'll answer via this email.
In your var_defns.sh file, did the ..._MAG values get set to -999.0 instead
of whatever values they have in config_defaults.sh?
…On Mon, Sep 14, 2020 at 6:13 PM JeffBeck-NOAA ***@***.***> wrote:
@gsketefian <https://github.com/gsketefian>, that's strange, I wonder why
my tests worked if I should have had this block of code in setup.sh instead
of the generate script?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/NOAA-EMC/regional_workflow/pull/291#issuecomment-692384169>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHM3ZYRSLMHS2PSLLJSTJH3SF2WUHANCNFSM4RGOOI6A>
.
--
Gerard Ketefian
Research Scientist
NOAA/OAR/ESRL/GSD/EMB, R/GSD1
325 Broadway
Boulder, CO 80305
phone: 303-497-6209
|
Collaborator
Author
|
Lol, yeah, that's because I deleted the message in GitHub after realizing
what was going on, but you still got the email. So, the magnitude values
in the var_defns.sh file did not get changed to -999.0, but they did in
input.nml, due to that block of code being in the generate script and not
in setup.sh. I'll get that fixed.
…On Mon, Sep 14, 2020 at 6:57 PM gsketefian ***@***.***> wrote:
What's strange is I don't see this particular comment on the PR's
conversation page! Anyway, I'll answer via this email.
In your var_defns.sh file, did the ..._MAG values get set to -999.0 instead
of whatever values they have in config_defaults.sh?
On Mon, Sep 14, 2020 at 6:13 PM JeffBeck-NOAA ***@***.***>
wrote:
> @gsketefian <https://github.com/gsketefian>, that's strange, I wonder
why
> my tests worked if I should have had this block of code in setup.sh
instead
> of the generate script?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
https://github.com/NOAA-EMC/regional_workflow/pull/291#issuecomment-692384169
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AHM3ZYRSLMHS2PSLLJSTJH3SF2WUHANCNFSM4RGOOI6A
>
> .
>
--
Gerard Ketefian
Research Scientist
NOAA/OAR/ESRL/GSD/EMB, R/GSD1
325 Broadway
Boulder, CO 80305
phone: 303-497-6209
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/NOAA-EMC/regional_workflow/pull/291#issuecomment-692396352>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANFE566POP3WLEYUYY2LZZTSF23YRANCNFSM4RGOOI6A>
.
|
…nd "FALSE" from lowercase to uppercase, and move the "if false, then -999.0" block from the generate to the setup script
Collaborator
Author
|
@gsketefian, just added the commit referenced above. |
gsketefian
approved these changes
Sep 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Adds an "if" statement to the generate script to allow individual ad-hoc stochastic physics schemes to run without the others. If an ad-hoc scheme is not activated, its magnitude will be set to -999.0 to shut it off. Setting "do_shum/skeb/sppt" is insufficient unless all three schemes are "false," in which case nothing runs. If the model code is updated in the future to fix things, this PR can be reverted.
TESTS CONDUCTED:
Tested on Jet.