add SPP support for G-F deep convection#98
Merged
Conversation
JiliDong-NOAA
requested review from
Qingfu-Liu,
RuiyuSun,
dustinswales,
grantfirl,
gthompsnWRF and
haiqinli
as code owners
haiqinli
approved these changes
Aug 21, 2023
This was referenced Aug 21, 2023
Qingfu-Liu
approved these changes
Aug 23, 2023
dustinswales
requested changes
Aug 23, 2023
Collaborator
dustinswales
left a comment
dustinswales
left a comment
There was a problem hiding this comment.
Looks good. Just a small request.
| rand_clos(:,:) = 0. | ||
| else | ||
| do i=1,im | ||
| spp_wts_cu_deep_tmp=min(max(-1.0, spp_wts_cu_deep(i,1)),1.0) |
Collaborator
There was a problem hiding this comment.
It's best to be explicit with the types you are passing to intrinsics.
Replace min(max(-1.0, spp_wts_cu_deep(i,1)),1.0)
With min(max(-1.kind_phys, spp_wts_cu_deep(i,1)),1._kind_phys)
Author
There was a problem hiding this comment.
updated as requested. Thanks for the suggestion @dustinswales
dustinswales
approved these changes
Aug 23, 2023
Collaborator
dustinswales
left a comment
dustinswales
left a comment
There was a problem hiding this comment.
@JiliDong-NOAA Thanks for making this change.
grantfirl
approved these changes
Aug 30, 2023
|
@grantfirl testing is complete on ufs-wm PR #1876. Are you able to merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is co-authored with Georg Grell and @haiqinli, including:
Related PRs for FV3 and ufs-weather-model will be submitted shortly.