Skip to content

Rollback changes to rain evaporation#81

Merged
grantfirl merged 1 commit into
ufs-community:small_fixes_GTfrom
AndersJensen-NOAA:rain_evap
Jun 16, 2023
Merged

Rollback changes to rain evaporation#81
grantfirl merged 1 commit into
ufs-community:small_fixes_GTfrom
AndersJensen-NOAA:rain_evap

Conversation

@AndersJensen-NOAA
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gthompsnWRF It's generally best to avoid creating branches on the authoritative repos, mostly to keep it lean, but also to avoid cases like this where code managers have to approve PRs into your working code base.

@grantfirl
Copy link
Copy Markdown
Collaborator

@AndersJensen-NOAA Can we make this change in #69 instead of making this its own PR? It's a little strange to have a PR (that hasn't been merged yet) to create a change and simultaneously have another to undo part of it.

@dustinswales
Copy link
Copy Markdown
Collaborator

@AndersJensen-NOAA Can we make this change in #69 instead of making this its own PR? It's a little strange to have a PR (that hasn't been merged yet) to create a change and simultaneously have another to undo part of it.

@grantfirl I think the problem is not that @AndersJensen-NOAA is trying to push to @gthompsnWRF's branch, but that Greg's branch is on the ufs-community fork, not his personal fork...

@grantfirl
Copy link
Copy Markdown
Collaborator

@AndersJensen-NOAA Can we make this change in #69 instead of making this its own PR? It's a little strange to have a PR (that hasn't been merged yet) to create a change and simultaneously have another to undo part of it.

@grantfirl I think the problem is not that @AndersJensen-NOAA is trying to push to @gthompsnWRF's branch, but that Greg's branch is on the ufs-community fork, not his personal fork...

Oh, I see. I didn't look at the PR target. @AndersJensen-NOAA please disregard. In this case, I think that we should just merge it in. Any objections?

@grantfirl grantfirl merged commit 279e52b into ufs-community:small_fixes_GT Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants