PBL and Convection and Microphysics update for HR2#65
Conversation
Qingfu-Liu
requested review from
JongilHan66,
dustinswales,
grantfirl and
lisa-bengtsson
as code owners
|
I have compiled the code with two suites (FV3_GFS_v16, FV3_GFS_v17_p8) and successfully run two tests (control_c384, control_p8). |
| ! tem2 = (u1(i,1)/dz)**2 | ||
| ! tem2 = tem2+(v1(i,1)/dz)**2 | ||
| ! tem2 = cs0*sqrt(e2(i,n))*sqrt(tem2) | ||
| ! |
There was a problem hiding this comment.
You may want to consider removing the lines that are commented out.
lisa-bengtsson
left a comment
lisa-bengtsson
left a comment
There was a problem hiding this comment.
Looks good, the reduction of the dry bias is a welcomed contribution.
|
***@***.***, thanks, just removed the comment lines.*
…On Mon, Apr 24, 2023 at 6:33 AM lisa-bengtsson ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good, the reduction of the dry bias is a welcomed contribution.
—
Reply to this email directly, view it on GitHub
<#65 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGTS6UQDIQ6RRVP7KNUI3K3XCZJG7ANCNFSM6AAAAAAXHIRMFU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
| endif | ||
|
|
||
| ! | ||
| ! if tkemean>tkcrt, tem=1+tkemean/tkcrt, clamt=tem*clam |
There was a problem hiding this comment.
Consider removing these commented lines for cleaner code.
| endif | ||
| enddo | ||
| ! | ||
| ! if tkemean>tkcrt, clamt=(1+tkemean/tkcrt)*clam |
There was a problem hiding this comment.
Consider removing the commented code.
| ! | ||
| ! tem2 = stress(i)*spd1(i)/zl(i,1) | ||
| tem2 = stress(i)*ustar(i)*phim(i)/(vk*zl(i,1)) | ||
| ! tem2 = stress(i)*ustar(i)*phim(i)/(vk*zl(i,1)) |
There was a problem hiding this comment.
Consider removing commented code. Old versions will always be saved in git history.
|
@Qingfu-Liu Are you going to open PRs into fv3atm and ufs-weather-model for this? |
|
@grant Firl - NOAA Affiliate ***@***.***> , Thanks for your
suggestions, I will remove the comment lines. I will open PRs for fv3atm
and ufs-weather-model.
…On Mon, Apr 24, 2023 at 3:20 PM Grant Firl ***@***.***> wrote:
@Qingfu-Liu <https://github.com/Qingfu-Liu> Are you going to open PRs
into fv3atm and ufs-weather-model for this?
—
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGTS6UW2QLUFIHQEUOUF4VLXC3HANANCNFSM6AAAAAAXHIRMFU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I just received an e-mail from microphysics developer, he want to make some small changes for HR2, I may combine the code changes to this PR if there is only a small code changes |
|
Ruiyu Sun made small changes to "radiation_clouds.f", and I added him to review the new commit. There are no changes to the existing PR#65 |
Qingfu-Liu
changed the title
| & (k >= kbx .and. k <= kmx)) then | ||
| dz = zi(i,k+1) - zi(i,k) | ||
| tem = f1(i,k) * dz | ||
| tem = f1(i,k) * del(i,k) / grav |
There was a problem hiding this comment.
It looks like there is a 1/g local variable declared in this routine. Please replace the division by "grav" with the multiplication by "gravi".
dustinswales
left a comment
dustinswales
left a comment
There was a problem hiding this comment.
Looks good. Nice job. Just a small suggestion on using a constant in one of the modules.
| do i = 1,im | ||
| dz = zi(i,k+1) - zi(i,k) | ||
| tem = f1(i,k) * dz | ||
| tem = f1(i,k) * del(i,k) / grav |
|
Thanks. I will change it to multiplication
…On Tue, May 2, 2023 at 12:46 PM dustinswales ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good. Nice job. Just a small suggestion on using a constant in one
of the modules.
------------------------------
In physics/satmedmfvdifq.F
<#65 (comment)>
:
> @@ -1720,8 +1742,7 @@ subroutine satmedmfvdifq_run(im,km,ntrac,ntcw,ntrw, &
enddo
do k = 1,km
do i = 1,im
- dz = zi(i,k+1) - zi(i,k)
- tem = f1(i,k) * dz
+ tem = f1(i,k) * del(i,k) / grav
ditto
—
Reply to this email directly, view it on GitHub
<#65 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGTS6URYOZCGVZVX2MEGCS3XEE25RANCNFSM6AAAAAAXHIRMFU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Tests are done at ufs-community/ufs-weather-model#1731. @grantfirl @dustinswales Can you go ahead to merge this pr? |
8 participants
This PR is created for HR2 with the updated PBL & convection codes (code from Jongil Han and Ruiyu Sun). I have resolved the conflicts of the codes with the current repository. The overall features for the updates:
to reduce the negative hurricane intensity biases, a parameterization for environmental wind shear effect is included in the GFS cumulus convection and TKE-EDMF PBL schemes. In addition, the entrainment rates in the GFS cumulus convection and TKE-EDMF PBL schemes are enhanced proportional to the sub-cloud or PBL mean TKE (turbulent kinetic energy) when TKE is larger than a threshold value.
A detailed description and test results with the NCEP GFS for the impacts of the new parameterization of environmental wind shear effect and TKE-dependent entrainment enhancement on hurricane intensity and track forecasts are given here.
To enhance the underestimated CAPE forecasts in the GFS, the entrainment rate in the TKE-EDMF PBL scheme is increased as a function of vegetation fraction and surface roughness length. A detailed description and test results with the NCEP GFS for this update are given here.