Updates to the MYNN surface-layer scheme#58
Conversation
|
@grantfirl You may want to remove @ChunxiZhang-NOAA as a code owner. |
@joeolson42 @grantfirl I opened a PR into this branch replacing Chunxi @Qingfu-Liu. |
|
Thanks @dustinswales. Joe is testing this PR individually before we try to combine with #49. I think the latest status is that both individual PRs (this one and #49) are debugging a couple unexpected RT failures, which will be much easier to debug independently. |
grantfirl
left a comment
There was a problem hiding this comment.
This looks fine to me, assuming RT results are as-expected. As mentioned, there is definitely still room for constant cleanup in a later PR, or when @joeolson42 does a more thorough re-write as discussed offline.
|
All tests successfully compiled and ran to completion. All tests using the MYNN surface-layer scheme were expected to fail the checks due to changes to the solution. The log files are attached. |
MYNN surface-layer scheme update:
Companion PRs:
ufs-community/ufs-weather-model#1678
NOAA-EMC/ufsatm#640