Combo for #41 and #45#53
Merged
Merged
Conversation
…ensemble perturbations
|
thanks @grantfirl ! |
5 tasks
37 tasks
grantfirl
requested review from
ChunxiZhang-NOAA and
dustinswales
as code owners
Collaborator
Author
|
@dustinswales Please review this when you get a chance. It just combines #41 and #45. |
dustinswales
approved these changes
Mar 14, 2023
Collaborator
dustinswales
left a comment
dustinswales
left a comment
There was a problem hiding this comment.
@grantfirl Thanks for combining these!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This combines work from @climbfuji: #41 and @Jili-Dong : #45
This updates CMakeLists.txt to require the sp library and adds 3 input parameters for the NSSL MP scheme. No baseline changes are expected for either change.