Changed UGWP diagnostic variable declaration intents from 'out' to 'inout'#40
Merged
grantfirl merged 3 commits intoFeb 22, 2023
Merged
Conversation
mdtoyNOAA
requested review from
ChunxiZhang-NOAA and
grantfirl
as code owners
37 tasks
ChunxiZhang-NOAA
approved these changes
Feb 14, 2023
Collaborator
Author
|
@ChunxiZhang-NOAA I forgot to change the "intent" settings for the UGWP diagnostic variables in "drag_suite.meta". I've just changed them from "out" to "inout" to correspond to the changes in "drag_suite.F90". I'm about to push this new commit to my branch. |
ChunxiZhang-NOAA
approved these changes
Feb 14, 2023
|
@mdtoyNOAA Because those are diagnostic variables, the bug fixes will not change model results, right? |
Collaborator
Author
|
@ChunxiZhang-NOAA That is correct. |
|
@mdtoyNOAA Good to know, thanks. |
dustinswales
approved these changes
Feb 15, 2023
Collaborator
dustinswales
left a comment
dustinswales
left a comment
There was a problem hiding this comment.
@mdtoyNOAA Looks good!
grantfirl
approved these changes
Feb 15, 2023
… into ufs/dev_drag_suite_intent_mods
|
ufs-wm test is done: ufs-community/ufs-weather-model#1597. @ChunxiZhang-NOAA can you merge the pr? |
|
Maybe @grantfirl can merge if @ChunxiZhang-NOAA is not available? |
|
if @ChunxiZhang-NOAA is not available, @grantfirl can you merge this pr? |
dustinswales
pushed a commit
that referenced
this pull request
Nov 2, 2023
Changed UGWP diagnostic variable declaration intents from 'out' to 'inout'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes Issue #37. The UGWP diagnostic variables (i.e., dusfc_ms, dvsfc_ms, tdaux2d_ms, datauy2d_ms, etc.) are declared with "intent(out)" and initialized in module unified_ugwp.F90, then they are passed to subroutine "drag_suite_run" (in drag_suite.F90). In this subroutine, the UGWP diagnostic variables should have been declared with "intent(inout)" instead of "intent(out)". This PR fixes this.