Skip to content

RRTMGP refactoring#34

Merged
ChunxiZhang-NOAA merged 26 commits into
ufs-community:ufs/devfrom
dustinswales:rrtmgp_refactor
Feb 7, 2023
Merged

RRTMGP refactoring#34
ChunxiZhang-NOAA merged 26 commits into
ufs-community:ufs/devfrom
dustinswales:rrtmgp_refactor

Conversation

@dustinswales
Copy link
Copy Markdown
Collaborator

@dustinswales dustinswales commented Jan 18, 2023

This PR contains changes to the RRTMGP physics.

  • Major refactoring of RRTMGP interstitials. collapse all rrtmgp_lw(sw) scheme files into rrtmgp_lw(sw)_main schemes. This reduces the number of Interstitial fields needed by the GP scheme and allows us to use the rte-rrtmgp submodule directly, w/o the need for a special branch containing the CCPP hooks.
  • For longwave radiation calculation, add "blocking" capability to main loop.
  • Fix bug in coupling of RRTMGP shortwave radiation to surface.
  • CMake cleanup.

dustinswales and others added 21 commits April 11, 2022 19:41
Comment thread physics/GFS_rrtmgp_cloud_mp.F90 Outdated
Comment thread physics/GFS_rrtmgp_post.F90 Outdated
Comment thread physics/GFS_rrtmgp_pre.F90
Comment thread physics/GFS_rrtmgp_pre.F90
Comment thread physics/GFS_rrtmgp_sw_pre.F90
Comment thread physics/rrtmgp_aerosol_optics.F90
Comment thread physics/rrtmgp_aerosol_optics.F90
Comment thread physics/rrtmgp_lw_cloud_optics.F90
Comment thread physics/rrtmgp_lw_cloud_optics.F90
Comment thread physics/rrtmgp_sw_main.F90 Outdated
@grantfirl
Copy link
Copy Markdown
Collaborator

@dustinswales I'm finished looking through this. Looks fine to me for the most part, with some worries about uninitialized intent(out) variables. It seems like every small scheme that was deleted ended up in the SW or LW main schemes? It's a little difficult to follow code moving between files in the GitHub interface (without looking really hard).

@dustinswales
Copy link
Copy Markdown
Collaborator Author

@dustinswales I'm finished looking through this. Looks fine to me for the most part, with some worries about uninitialized intent(out) variables. It seems like every small scheme that was deleted ended up in the SW or LW main schemes? It's a little difficult to follow code moving between files in the GitHub interface (without looking really hard).

@grantfirl Thanks for your review. I addressed your concerns about the intent of some variables.

I admit this is hard to follow, my apologizes, it's a total restructuring of how GP is implemented in the CCPP.

Comment thread physics/GFS_rrtmgp_cloud_mp.F90
@jkbk2004
Copy link
Copy Markdown

jkbk2004 commented Feb 1, 2023

We are about to start working on ufs-community/ufs-weather-model#1571. @dustinswales can you mark out unsolved conversations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants