Enable use of prognostic closure in convection at coarse resolutions for SFSv1#291
Merged
Merged
Conversation
lisa-bengtsson
requested review from
JongilHan66,
Qingfu-Liu,
dustinswales,
grantfirl and
rhaesung
as code owners
JongilHan66
approved these changes
Jun 9, 2025
mzhangw
reviewed
Jun 9, 2025
13 tasks
grantfirl
approved these changes
Jun 13, 2025
Collaborator
|
@lisa-bengtsson Have you run RTs yet? I don't see a UWM PR. I'm happy to combine this with something else, although if baselines are changed as you mentioned, it might make it more difficult. |
Collaborator
Author
|
@grantfirl there is a UWM PR here: ufs-community/ufs-weather-model#2771 I uploaded the test_changes.list so you can see which baselines are updated if that helps. |
Collaborator
Doh. I see it now. Thanks. We'll see if it make sense to combine with something else. I'll let you know. |
Qingfu-Liu
approved these changes
Jun 13, 2025
rhaesung
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very small PR that can easily be merged with other PR's.
Currently there is a dx threshold to not use the prognostic closure in saSAS convection for resolutions coarser than 30km. After testing and evaluation for the Seasonal Forecast System (SFS) linked here, we would like to activate this closure also for SFSv1. Thus, to be able to use this closure in SFS (~50km target) this threshold need to be made larger.
In this PR I'm also making a small correction (units from frac to Pa/s for the updraft omega).
This pull-request will need new baselines for any coarser RT test than C384 using the saSAS convection scheme. It does not impact GFSv17 or GEFSv13 at C1152 or C384 resolution.
Issue in ufs-weather-model: ufs-community/ufs-weather-model#2770