The final physics update PR to RRFS.v1#211
Conversation
haiqinli
requested review from
Qingfu-Liu,
dustinswales,
grantfirl and
mzhangw
as code owners
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
Minor changes requested to metadata and comments
dustinswales
left a comment
dustinswales
left a comment
There was a problem hiding this comment.
@haiqinli Thanks for making these changes. Just a few tiny requests.
|
@haiqinli @dustinswales - can I make this change (above for precip_factor) directly or does Haiqin need to do it? |
It depends on whether you have push access to Haiqin's fork. If he adds your GitHub user as a collaborator on his fork of ccpp-physics, then you should have push permissions and can make commits. |
|
@jordanschnell I am back, and I can update the PR to include your changes. |
|
@grantfirl Some smoke code updates will come next Monday. Let's hold this PR a couple of days. Thanks. |
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
Minor changes requested to metadata and comments
|
@haiqinli Do you still want to hold this, or should it be scheduled on the merge queue? |
@grantfirl I am updating this PR, and we can schedule it on the queue. Thanks. |
haiqinli
force-pushed
the
production/RRFS.v1-final
branch
from
6e878ba to
2d590da
Compare
|
@grantfirl @dustinswales @MatthewPyle-NOAA Tests are done at ufs-community/ufs-weather-model#2298. Can you merge this pr? |
|
@jkbk2004 Ability to merge looks to be held up by an old block. |
7 participants
This is the final physics updates PR to RRFS.v1, and it includes some minor physics bug fixies of RUC LSM, FMS and smoke/dust.