Fix .gitmodule bug#168
Merged
dustinswales merged 1 commit intoFeb 23, 2024
Merged
Conversation
dustinswales
requested review from
Qingfu-Liu,
grantfirl and
mzhangw
as code owners
Qingfu-Liu
approved these changes
Feb 7, 2024
climbfuji
approved these changes
Feb 7, 2024
|
Resolves #165 |
mkavulich
approved these changes
Feb 7, 2024
Collaborator
|
@dustinswales @mkavulich @climbfuji Let's combine this with #150, which may also be combined with #149. None of them change baselines. |
Collaborator
@climbfuji If you are OK with this strategy, would you pull this PR into your branch for #150, please? |
Collaborator
Author
|
Thanks @climbfuji for cleaning up my many messes! |
Ok, let me do that |
|
done |
mzhangw
approved these changes
Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.