Supplementary physics updates for RRFS code freeze#161
Conversation
haiqinli
requested review from
Qingfu-Liu,
dustinswales,
grantfirl and
mzhangw
as code owners
|
@grantfirl @Qingfu-Liu Since this pr is priority, can we ask to review for the update? @haiqinli Once the remarks and updates are approved, it might be helpful to mark out resolved. |
@jkbk2004 I re-reviewed. @haiqinli Please see the comment about your new |
@haiqinli Is it possible to make a quick follow-up? If possible, we like to proceed to commit the pr today or tomorrow. |
|
@jkbk2004 I am working on it, and will update soon. Thanks. |
|
@jkbk2004 This PR is reviewed and approved, so ready for testing as soon as all branches are updated. |
dustinswales
left a comment
dustinswales
left a comment
There was a problem hiding this comment.
Looks fine to me. Just a few requested changes wrt precision.
| !Add condition for falling/settling into low-RH layers, so at least | ||
| !some cloud fraction is applied for all qc, qs, and qi. | ||
| rh_hack= rh(k) | ||
| wt2 = min(max( zagl - pblh2, 0.0 )/300., 1.0) |
There was a problem hiding this comment.
Please change to min(max( zagl - pblh2, 0._kind_phys )/300., 1._kind_phys)
| !cld_factor = 1.0 + fac_damp*MAX(0.0, ( RH(k) - 0.75 ) / 0.26 )**1.9 !HRRRv4 | ||
| !cld_factor = 1.0 + fac_damp*min((max(0.0, ( RH(k) - 0.92 )) / 0.25 )**2, 0.3) | ||
| cld_factor = 1.0 + fac_damp*min((max(0.0, ( RH(k) - 0.92 )) / 0.145)**2, 0.35) | ||
| cld_factor = 1.0 + fac_damp*min((max(0.0, ( RH(k) - 0.92 )) / 0.145)**2, 0.37) |
There was a problem hiding this comment.
Replace w/ fac_damp*min((max(0._kind_phys, ( RH(k) - 0.92 )) / 0.145)**2, 0.37_kind_phys)
| INTEGER :: nv, i, j, k, kp1, kp2 | ||
| INTEGER :: icall=0 | ||
| INTEGER, DIMENSION(ims:ime, jms:jme), INTENT (OUT) :: k_min, k_max ! Min and max ver. levels for BB injection spread | ||
| REAL, DIMENSION(ims:ime, jms:jme), INTENT (OUT) :: uspdavg2, hpbl_thetav2 ! SRB |
There was a problem hiding this comment.
This should be REAL(kind_phys)
@dustinswales These changes might need to wait until the next round of changes. I think that this has already been combined with #94 and they're doing final RTs. |
@grantfirl Snap, I'm too late! |
We will file a git issue to bring it with next PR. |
* add gflux * add runoff and drain to land coupling * add exchange coefficents * add zvfun to land coupling * minor fix in GFS type definitions * update sfc_land * remove Sa_ua and Sa_va from couling fields * fix prefix of snow area fraction standard name * rename exchange fields to follow inst convention * "Supplementary physics updates for RRFS code freeze" * update ccpp/physics by merging ufs-community#161 --------- Co-authored-by: Ufuk Turuncoglu <ufuk.turuncoglu@noaa.gov> Co-authored-by: Haiqin.Li <Haiqin.Li@noaa.gov>
5 participants
This is a supplementary physics updates (MYNN, GF, RUC_LSM, smoke and dust) PR for RRFS code freeze.