fix crash when using clm lake and GFS PBL/sfclay#148
Merged
dustinswales merged 7 commits intoDec 21, 2023
Conversation
JiliDong-NOAA
requested review from
JongilHan66,
Qingfu-Liu,
dustinswales,
grantfirl and
tanyasmirnova
as code owners
JongilHan66
approved these changes
Dec 19, 2023
dustinswales
approved these changes
Dec 19, 2023
Collaborator
dustinswales
left a comment
dustinswales
left a comment
There was a problem hiding this comment.
The changes look fine to me, just a small comment on the formatting
Qingfu-Liu
approved these changes
Dec 19, 2023
|
|
||
|
|
||
| if (.not. icy(i)) then | ||
| flag_lakefreeze(i)=.true. |
Collaborator
There was a problem hiding this comment.
@JiliDong-NOAA Jili, should it be if(icy(i)) then when the lake grid point is frozen?
Collaborator
There was a problem hiding this comment.
@JiliDong-NOAA I see now, that this will be true only for new ice points. I agree with this change. Thank you.
tanyasmirnova
approved these changes
Dec 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to fix the RRFS ensemble member crash when combining clm lake and GFS PBL/sfclay:
#141
A new flag is created to track new freezing lake ice and let sfc_diff to calculate stability variables over the new icy grids for GFS PBL in the second surface loop, which otherwise will remain as missing values.