You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This upgrades the libraries for UFS_Utils to those of spack-stack version 1.6.0. Most notably, this upgrades the following libraries:
netcdf-fortran 4.6.0 -> 4.6.1
esmf 8.4.2 -> 8.6.0
sp 2.3.3 -> 2.5.0
Also, support for Cheyenne is removed as that system has gone offline.
Regression tests on Hera, Orion, Hercules, and Jet all showed the same differences
Minor differences in U- and V-winds in several chgres tests. @GeorgeGayno-NOAA confirmed these were minor.
The mx100cpld_gridgen test showed differences in col and S variables. @DeniseWorthen confirmed these were minor and had to do with the way ESMF regridded the variables.
One test differed on Orion/Hercules, Jet, and WCOSS2:
The global_cycleC192 landinc soil-NoahMP test produced identical surface .inc files on Hera, but on Orion/Hercules, Jet and
WCOSS2 the tiled sfcanl files had an extra checksum attribute in the hice and fice fields. However, the values of the fields were identical. This probably means the baseline data needs to be updated on these platforms.
TESTS CONDUCTED:
If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.
Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera, Hercules and WCOSS2).
Compile branch on Hera using GNU.
Compile branch in 'Debug' mode on WCOSS2.
Run unit tests locally on any Tier 1 machine.
Run relevant consistency tests locally on all Tier 1 machine.
The global_cycle regression test baseline was recently updated under a previous PR. So, the 'checksum' difference is no longer an issue. When I run your branch (4e6757a) on Hera, all global_cycle tests pass.
The global_cycle regression test baseline was recently updated under a previous PR. So, the 'checksum' difference is no longer an issue. When I run your branch (4e6757a) on Hera, all global_cycle tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
This upgrades the libraries for UFS_Utils to those of spack-stack version 1.6.0. Most notably, this upgrades the following libraries:
Also, support for Cheyenne is removed as that system has gone offline.
Regression tests on Hera, Orion, Hercules, and Jet all showed the same differences
mx100cpld_gridgentest showed differences incolandSvariables. @DeniseWorthen confirmed these were minor and had to do with the way ESMF regridded the variables.One test differed on Orion/Hercules, Jet, and WCOSS2:
global_cycleC192 landinc soil-NoahMPtest produced identical surface.incfiles on Hera, but on Orion/Hercules, Jet andWCOSS2 the tiled
sfcanlfiles had an extrachecksumattribute in thehiceandficefields. However, the values of the fields were identical. This probably means the baseline data needs to be updated on these platforms.TESTS CONDUCTED:
If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.
Describe any additional tests performed.
ISSUE:
#884