Skip to content

Orog gsl improvements #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GeorgeGayno-NOAA merged 4 commits into from
Dec 7, 2022
Merged

Orog gsl improvements #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f9bf0b
Fixed issue with negative bias in orographic asymmetery (OA) fields a…
mdtoyNOAA Nov 22, 2022
3f265ff
Merge branch 'develop' of https://github.com/ufs-community/UFS_UTILS …
mdtoyNOAA Nov 22, 2022
08066df
Merge branch 'develop' of https://github.com/ufs-community/UFS_UTILS …
mdtoyNOAA Nov 29, 2022
17d39be
Merge branch 'develop' of https://github.com/ufs-community/UFS_UTILS …
mdtoyNOAA Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 30 additions & 12 deletions sorc/orog_mask_tools.fd/orog_gsl.fd/module_gsl_oro_data_lg_scale.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,9 +611,15 @@ subroutine calc_gsl_oro_data_lg_scale(tile_num,res_indx,halo)
nu = 0
nd = 0
do jj = 1,jj_m
do ii = 1,ii_m/2 ! left half of box
if ( zs(ii,jj) > zs_mean ) nu = nu + 1
end do
if(mod(ii_m,2).eq.0.) then
do ii = 1,ii_m/2 ! left half of box
if ( zs(ii,jj) > zs_mean ) nu = nu + 1
end do
else
do ii = 1,ii_m/2+1 ! left half of box
Comment thread
GeorgeGayno-NOAA marked this conversation as resolved.
if ( zs(ii,jj) > zs_mean ) nu = nu + 1
end do
endif
do ii = ii_m/2 + 1, ii_m ! right half of box
if ( zs(ii,jj) > zs_mean ) nd = nd + 1
end do
Expand All @@ -628,11 +634,19 @@ subroutine calc_gsl_oro_data_lg_scale(tile_num,res_indx,halo)
! OA2 -- orographic asymmetry in South direction
nu = 0
nd = 0
do jj = 1,jj_m/2 ! bottom half of box
do ii = 1,ii_m
if ( zs(ii,jj) > zs_mean ) nu = nu + 1
end do
end do
if(mod(jj_m,2).eq.0.) then
do jj = 1,jj_m/2 ! bottom half of box
do ii = 1,ii_m
if ( zs(ii,jj) > zs_mean ) nu = nu + 1
end do
end do
else
do jj = 1,jj_m/2+1 ! bottom half of box
do ii = 1,ii_m
if ( zs(ii,jj) > zs_mean ) nu = nu + 1
end do
end do
endif
do jj = jj_m/2 + 1,jj_m ! top half of box
do ii = 1, ii_m
if ( zs(ii,jj) > zs_mean ) nd = nd + 1
Expand All @@ -651,10 +665,12 @@ subroutine calc_gsl_oro_data_lg_scale(tile_num,res_indx,halo)
ratio = real(jj_m,real_kind)/real(ii_m,real_kind)
do jj = 1,jj_m
do ii = 1,ii_m
if ( nint(real(ii,real_kind)*ratio) < (jj_m - jj) ) then
if ( nint(real(ii,real_kind)*ratio) <= (jj_m - jj + 1) ) then
! south-west half of box
if ( zs(ii,jj) > zs_mean ) nu = nu + 1
else ! north-east half of box
endif
if ( nint(real(ii,real_kind)*ratio) >= (jj_m - jj + 1) ) then
! north-east half of box
if ( zs(ii,jj) > zs_mean ) nd = nd + 1
end if
end do
Expand All @@ -672,10 +688,12 @@ subroutine calc_gsl_oro_data_lg_scale(tile_num,res_indx,halo)
ratio = real(jj_m,real_kind)/real(ii_m,real_kind)
do jj = 1,jj_m
do ii = 1,ii_m
if ( nint(real(ii,real_kind)*ratio) < jj ) then
if ( nint(real(ii,real_kind)*ratio) <= jj ) then
! north-west half of box
if ( zs(ii,jj) > zs_mean ) nu = nu + 1
else ! south-east half of box
end if
if ( nint(real(ii,real_kind)*ratio) >= jj ) then
! south-east half of box
if ( zs(ii,jj) > zs_mean ) nd = nd + 1
end if
end do
Expand Down
42 changes: 30 additions & 12 deletions sorc/orog_mask_tools.fd/orog_gsl.fd/module_gsl_oro_data_sm_scale.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,9 +558,15 @@ subroutine calc_gsl_oro_data_sm_scale(tile_num,res_indx,halo, &
nu = 0
nd = 0
do jj = 1,jj_m
do ii = 1,ii_m/2 ! left half of box
if ( zs(ii,jj) > zs_mean ) nu = nu + 1
end do
if(mod(ii_m,2).eq.0.) then
do ii = 1,ii_m/2 ! left half of box
if ( zs(ii,jj) > zs_mean ) nu = nu + 1
end do
else
do ii = 1,ii_m/2+1 ! left half of box
if ( zs(ii,jj) > zs_mean ) nu = nu + 1
end do
endif
do ii = ii_m/2 + 1, ii_m ! right half of box
if ( zs(ii,jj) > zs_mean ) nd = nd + 1
end do
Expand All @@ -575,11 +581,19 @@ subroutine calc_gsl_oro_data_sm_scale(tile_num,res_indx,halo, &
! OA2 -- orographic asymmetry in South direction
nu = 0
nd = 0
do jj = 1,jj_m/2 ! bottom half of box
do ii = 1,ii_m
if ( zs(ii,jj) > zs_mean ) nu = nu + 1
end do
end do
if(mod(jj_m,2).eq.0.) then
do jj = 1,jj_m/2 ! bottom half of box
do ii = 1,ii_m
if ( zs(ii,jj) > zs_mean ) nu = nu + 1
end do
end do
else
do jj = 1,jj_m/2+1 ! bottom half of box
do ii = 1,ii_m
if ( zs(ii,jj) > zs_mean ) nu = nu + 1
end do
end do
endif
do jj = jj_m/2 + 1,jj_m ! top half of box
do ii = 1, ii_m
if ( zs(ii,jj) > zs_mean ) nd = nd + 1
Expand All @@ -598,10 +612,12 @@ subroutine calc_gsl_oro_data_sm_scale(tile_num,res_indx,halo, &
ratio = real(jj_m,real_kind)/real(ii_m,real_kind)
do jj = 1,jj_m
do ii = 1,ii_m
if ( nint(real(ii,real_kind)*ratio) < (jj_m - jj) ) then
if ( nint(real(ii,real_kind)*ratio) <= (jj_m - jj + 1) ) then
! south-west half of box
if ( zs(ii,jj) > zs_mean ) nu = nu + 1
else ! north-east half of box
endif
if ( nint(real(ii,real_kind)*ratio) >= (jj_m - jj + 1) ) then
! north-east half of box
if ( zs(ii,jj) > zs_mean ) nd = nd + 1
end if
end do
Expand All @@ -619,10 +635,12 @@ subroutine calc_gsl_oro_data_sm_scale(tile_num,res_indx,halo, &
ratio = real(jj_m,real_kind)/real(ii_m,real_kind)
do jj = 1,jj_m
do ii = 1,ii_m
if ( nint(real(ii,real_kind)*ratio) < jj ) then
if ( nint(real(ii,real_kind)*ratio) <= jj ) then
! north-west half of box
if ( zs(ii,jj) > zs_mean ) nu = nu + 1
else ! south-east half of box
end if
if ( nint(real(ii,real_kind)*ratio) >= jj ) then
! south-east half of box
if ( zs(ii,jj) > zs_mean ) nd = nd + 1
end if
end do
Expand Down