Skip to content
Merged
Changes from 10 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
29fc351
3
GeorgeVandenberghe-NOAA Feb 22, 2021
83ce4a5
added a few ineffective doxygen commands to sorc/emcsfc_snow2mdl.fd/g…
GeorgeVandenberghe-NOAA Feb 22, 2021
2fd2491
removed test build files
GeorgeVandenberghe-NOAA Feb 22, 2021
d394abd
changes to add documentation to sorc/emcsfc_snow2mdl.fd/grib_utils.f
GeorgeVandenberghe-NOAA Feb 22, 2021
e5afa82
added skgb2 docblock into grib_check docblock. This is not permanent…
GeorgeVandenberghe-NOAA Feb 22, 2021
342194e
Merge branch 'develop' into gwv
edwardhartnett Feb 23, 2021
f43e11a
added formatting changes to grib_utils.f to improve appearnance and
GeorgeVandenberghe-NOAA Feb 23, 2021
1d2c62e
added repaired grib_utils.f file . This is the good one made by Ed Ha…
GeorgeVandenberghe-NOAA Feb 23, 2021
c4312a9
added model_grid.f changes.
GeorgeVandenberghe-NOAA Feb 23, 2021
ae5ff63
Merge remote-tracking branch 'upstream/develop' into gwv
GeorgeVandenberghe-NOAA Feb 23, 2021
b9512ca
moved contains to before docblock, fixed na comments in docblock, rem…
GeorgeVandenberghe-NOAA Feb 23, 2021
81e3dcc
doxygenated snowdat.f
GeorgeVandenberghe-NOAA Feb 24, 2021
0266c7d
repaired model_grid.f and snowdat.f doxygen blocks to remove generic …
GeorgeVandenberghe-NOAA Feb 24, 2021
f818f94
added @note to sections of snowdat.f
GeorgeVandenberghe-NOAA Feb 24, 2021
3012407
repaird author tag misformat and removed extraneous documentation spaces
GeorgeVandenberghe-NOAA Feb 24, 2021
01c51d6
added snow2mdl doxygen, round 1
GeorgeVandenberghe-NOAA Feb 24, 2021
09693a8
Merge branch 'develop' into gwv
edwardhartnett Feb 25, 2021
6556143
corrected multiple consecutive !! space issues, moved @author to bot…
GeorgeVandenberghe-NOAA Feb 25, 2021
46cff79
removed additional !! subprogram missed in previous proofreading
GeorgeVandenberghe-NOAA Feb 25, 2021
dba8041
corrected @date directives in snowdat.f
GeorgeVandenberghe-NOAA Feb 26, 2021
db0f1b8
added doxygen block to program_setup.f
GeorgeVandenberghe-NOAA Feb 26, 2021
c1f7306
added SOME documentation to mtnlm7_oclsm.f Most routines remain und…
GeorgeVandenberghe-NOAA Feb 26, 2021
e286081
Merge branch 'develop' into gwv
edwardhartnett Feb 26, 2021
a1e4500
punctuated sentences, removed hyphens, removed double param definitions
GeorgeVandenberghe-NOAA Feb 26, 2021
cbcefde
added module <-> specification matching docblock to snowdat.f First …
GeorgeVandenberghe-NOAA Feb 26, 2021
b932645
added complete sentences to documentation. fixed spacing in author …
GeorgeVandenberghe-NOAA Mar 1, 2021
1fa6597
Merge branch 'develop' into gwv
edwardhartnett Mar 1, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 46 additions & 50 deletions sorc/emcsfc_snow2mdl.fd/model_grid.f
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
!> @file
!! @brief Read in data defining the model grid.
!!
!! @author gayno org: w/np2 @date 2005-dec-16
!!@author gayno org: w/np2 @date 2005-dec-16

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank space before author tag.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank space before author tag.

!!
!! program history log:
!! - 2005-dec-16 gayno - initial version
Expand Down Expand Up @@ -58,57 +58,53 @@ module model_grid
real, allocatable :: lsmask_mdl_sav (:,:)
real :: resol_mdl ! in km

contains
!>
Comment thread
edwardhartnett marked this conversation as resolved.
Outdated
!! @brief read latitude, longitude, land/sea mask on the model grid.
!!
!! @author George Gayno org: w/np2 @date 2005-dec-16
!!
!!
!! program history log:
!! 2005-dec-16 gayno - initial version
!! 2007-nov-30 gayno - improved method for thinning gfs grids
!! added nam b-grids
!! 2014-sep-29 gayno - add option to read lat,lon and mask
!! data in grib2.
!!
!! usage: call read_mdl_grid_info

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the entire usage line. Doxygen does this automatically.

!!
!! input argument list: n/a

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove any documentation element that says n/a or none. It is not conveying information.

!!
!! output argument list: n/a
!!
!! files:
!! inputs:
!! - model latitudes (grib 1 or grib 2)
Comment thread
edwardhartnett marked this conversation as resolved.
!! - model longitudes (grib 1 or grib 2)
!! - model landmask (grib 1 or grib 2)
!! - # pts per row, gfs grid (the "lonsperlat" file, ascii)
!!
!! outputs: none

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove lines which are just "none"

!!
!! condition codes: all fatal
!! 76 - bad open/read gfs "lonsperlat" file
!! 79 - unrecognized model grid
!! 80 - bad open model latitude file
!! 81 - bad read of model latitude grib 1 header
!! 82 - bad read of model latitude data
!! 83 - bad open model longitude file
!! 82 - bad read of model longitude data
!! 85 - bad open model landmask file
!! 86 - bad read of model landmask data
!! 90 - model latitude file not grib 1 or grib 2
!! 91 - model longitude file not grib 1 or grib 2
!! 92 - model landmask file not grib 1 or grib 2
!!
!! remarks: none.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all documentation sections which are just "none" or "N/A".

!!

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should not be a blank like, and the documentation block should be after "contains".

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved docblock to after the contains statement Added doxygen comments for snowdat.f.

contains
subroutine read_mdl_grid_info
!$$$ subprogram documentation block
!
! subprogram: read_mdl_grid_info
! prgmmr: gayno org: w/np2 date: 2005-dec-16
!
! abstract: read latitude, longitude, land/sea mask on the
! model grid.
!
! program history log:
! 2005-dec-16 gayno - initial version
! 2007-nov-30 gayno - improved method for thinning gfs grids
! added nam b-grids
! 2014-sep-29 gayno - add option to read lat,lon and mask
! data in grib2.
!
! usage: call read_mdl_grid_info
!
! input argument list: n/a
!
! output argument list: n/a
!
! files:
! inputs:
! - model latitudes (grib 1 or grib 2)
! - model longitudes (grib 1 or grib 2)
! - model landmask (grib 1 or grib 2)
! - # pts per row, gfs grid (the "lonsperlat" file, ascii)
!
! outputs: none
!
! condition codes: all fatal
! 76 - bad open/read gfs "lonsperlat" file
! 79 - unrecognized model grid
! 80 - bad open model latitude file
! 81 - bad read of model latitude grib 1 header
! 82 - bad read of model latitude data
! 83 - bad open model longitude file
! 82 - bad read of model longitude data
! 85 - bad open model landmask file
! 86 - bad read of model landmask data
! 90 - model latitude file not grib 1 or grib 2
! 91 - model longitude file not grib 1 or grib 2
! 92 - model landmask file not grib 1 or grib 2
!
! remarks: none.
!
!$$$

use grib_mod ! grib 2 library

implicit none
Expand Down