Remove OPS snow and ice scripts#1089
Merged
BrianCurtis-NOAA merged 13 commits intoAug 12, 2025
Merged
Conversation
associated utility scripts. Update the global consistency test to run snow2mdl as the global workflow does. Fixes ufs-community#1058.
the global workflow template. Fixes ufs-community#1058.
'ush' scripts. Fixes ufs-community#1058.
global workflow. Rewrite the ice blend regression test to not use the 'ush' script. Fixes ufs-community#1058.
and wgrib2 modules instead of hardwiring them. At one point these modules were not working. Fixes ufs-community#1058.
test script to the version consistent with spack stack 1.9.2. Fixes ufs-community#1058.
Collaborator
DavidHuber-NOAA
left a comment
DavidHuber-NOAA
left a comment
There was a problem hiding this comment.
Changes look good to me. Thanks George!
DavidHuber-NOAA
approved these changes
Aug 6, 2025
Collaborator
Author
|
@BrianCurtis-NOAA - after #1086 is merged, I will update my branch and do a quick retest. |
Collaborator
|
@GeorgeGayno-NOAA it's merged, go ahead. |
Collaborator
Author
|
@BrianCurtis-NOAA - this is ready to go. |
BrianCurtis-NOAA
approved these changes
Aug 11, 2025
Collaborator
|
@GeorgeGayno-NOAA looks like you've tested based on 8b40146 and all tests passed. No baseline updates, so no need to adjust them. Looks good to merge to me, any objections? |
Collaborator
Author
No. Please merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
As requested by the global workflow team:
emcsfc_ice_blendandemcsfc_snow2mdlprograms.emcsfc_snow2mdlprogram.TESTS CONDUCTED:
If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.
ice_blendandsnow2mdlconsistency tests locally on all Tier 1 machines. Done using 8b40146. All tests passed as expected.DEPENDENCIES:
None.
DOCUMENTATION:
N/A
ISSUE:
Fixes #1058.