Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

Pagination tweaks and fixes #240

Merged
merged 1 commit into from
Nov 30, 2017
Merged

Pagination tweaks and fixes #240

merged 1 commit into from
Nov 30, 2017

Conversation

chocolateboy
Copy link
Contributor

  • fallback links:
    • select the last matching link rather than the first
    • use innerText rather than textContent
  • use a single regex for each pattern rather than an array
  • fix markup typo in test

@chocolateboy
pagination tweaks and fixes:
ee3cd3f 
- fallback links:
  - select the last matching link rather than the first
  - use `innerText` rather than `textContent`
- use a single regex for each pattern rather than an array
- fix markup typo in test
ueokande
ueokande approved these changes Nov 30, 2017
View reviewed changes
Copy link
Owner

@ueokande ueokande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@ueokande ueokande merged commit b18674d into ueokande:master Nov 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ueokande ueokande ueokande approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chocolateboy @ueokande