This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
Closing pinned tabs must be forced #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't like the use of |
|
Yes, |
|
@r3r57 woops, |
|
@ueokande sorry, I can't get it running at the moment. Is there a problem with the current |
|
@r3r57 |
added 3 commits
January 14, 2018 17:19
Added binding 'DD' to force tab close which also closes pinned tabs
|
@ueokande Alright, I successfully rebased my branches. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #229 pinned tabs now can only be closed with
DDwhich forces close without any check. In contrastdwill now check whether the tab is pinned or not and will only close regular tabs.