Add c-n, c-j, c-p, c-k, c-m to console keybind

[heavenshell]

Hi, first thank you for create nice and useful extension!

I add following behaviors to Vim-vixen.

• c-n, c-j for select next item.
• c-p, c-k for select previous item.
• c-m for select item.

These console keybinds are same as Vim(Vimperator)'s completion selector.

Please check and review this and it's very pleasure to give me advices.

Thank you.

[idlewan]

This is great, I was wondering how to use that list, I didn't notice that you had to use the tab key.
In addition to all of these, the up/down arrow keys should probably also be working to select lines.

[heavenshell]

In addition to all of these, the up/down arrow keys should probably also be working to select lines.

ah, right. I'll add later 👍

[heavenshell]

Add up/down arrow keys for select next/prev item ☺️

[idlewan]

Does this need a return as well?
I think returning anything from a listener function (the ones passed to addEventListener) is deprecated behavior, so probably no need to change anything.

[heavenshell]

nice catch! thx!

[heavenshell]

oh, I added it and missed to read your fixed comment :-p
Original code have return.
I think we should confirm to @ueokande .

[ueokande]

@heavenshell Thanks for your PR.
Your patch is not acceptable. I agree to use <C-N> and <C-P> to focus next and previous items and <C-M> to select item. They are also used in Vim.
In my experience, <C-J>, <C-K>, and arrow keys have not been commonly used for select items in console. What is a reason for tha decision to use these keys?

[heavenshell]

@ueokande Thank you for review my PR!

In my experience, , , and arrow keys have not been commonly used for select items in console. What is a reason for tha decision to use these keys?

arrow key is also Vim's completion selector behavior. So I added.

$ vim --clean
i<c-x><c-f><arrow down>

<c-j>, <c-k> are not Vim's default behavior but Vimperator's behavior.
But I can understand <c-j>, <c-k> is not common behavior.
So, if I drop <c-j>, <c-k>, could you accept this?

[heavenshell]

Drop <C-j>, <C-k> 😊

[ueokande]

Arrow keys seem completion from command-line history in Vim. I have a plan to implement is in the future. Please drop arrow keys from key maps.

[heavenshell]

@ueokande

Arrow keys seem completion from command-line history in Vim. I have a plan to implement is in the future. Please drop arrow keys from key maps.

This is so nice and make sense!
Drop arrow keys from console 👍

[ueokande]

@heavenshell In my environment (Linux, Firefox 58 developer edition), <C-N> does not work to select next item in completion. The new tab is opened by Firefox's key binding. How do I solve it?

[heavenshell]

@ueokande Thank you for telling me this.
Oh, I usally use macOS and did't notice about confilict with Firefox's keybind.

It's better to do followings

• if platform is Linux and state is opening console than ignore OS's default keybinds

IMHO, this is very difficult(I'm sorry, I'm WebExtensions newbie).

I'll continue to investigate this, but do you have any idea?
Sorry for bothering you...

P.S.
I found Shift-Ctrl-n move next at Linux(Ubuntu) + Firefox57...

[ueokande]

@heavenshell
I understood a situation on <C-N> binding issue. Some Firefox's short-cut keys are not overridden by WebExtensions. It is already reported in Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1320332

I would merge your PR, and register known problem in issues. I wish Mozilla will resolve it. 🙏
Thank you.

[ueokande]

#200

[ueokande]

It works

[heavenshell]

Thank you so much including this!!