Remove unwrap on line option, preventing DAP crash (helix-editor#9632)

* Remove unwrap on line option, preventing DAP crash, ref helix-editor#4683 * Update to fall back to existing values for option fields
uek-1 · Feb 24, 2024 · 2d60754 · 2d60754
1 parent ca3574b
commit 2d60754
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/helix-view/src/handlers/dap.rs b/helix-view/src/handlers/dap.rs
@@ -226,10 +226,15 @@ impl Editor {
                                     breakpoints.iter().position(|b| b.id == breakpoint.id)
                                 {
                                     breakpoints[i].verified = breakpoint.verified;
-                                    breakpoints[i].message = breakpoint.message.clone();
-                                    breakpoints[i].line =
-                                        breakpoint.line.unwrap().saturating_sub(1); // TODO: no unwrap
-                                    breakpoints[i].column = breakpoint.column;
+                                    breakpoints[i].message = breakpoint
+                                        .message
+                                        .clone()
+                                        .or_else(|| breakpoints[i].message.take());
+                                    breakpoints[i].line = breakpoint
+                                        .line
+                                        .map_or(breakpoints[i].line, |line| line.saturating_sub(1));
+                                    breakpoints[i].column =
+                                        breakpoint.column.or(breakpoints[i].column);
                                 }
                             }
                         }