add support for CSP nonces in createStyleTag #2601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that tiptap injects a style element into the page's
head
. This breaks when using a Content Security Policy that disallowsunsafe-inline
, as there is currently no way to add anonce
to the dynamic style element.As the injected CSS is in a typescript file and not a CSS file, there is no easy way to include it in the application bundle, and it differs from the default
prosemirror.css
.To resolve this, I added an option called
injectNonce
to tiptap which, when set, adds anonce
attribute to the dynamic style element.Another solution would of course be to refactor the style into a CSS file which can be imported alongside tiptap, avoiding the dynamic element entirely, but that would probably require more code changes.
Additionally, the
injectNonce
option could be handy if any other dynamic injection of styles or scripts is required in the future.I'm open to discussion, but it would be great if we could use this amazing editor with a CSP!