-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Type error in addOptions
when extending extension (regression introduced in 2.10.0)
#5852
Closed
1 task done
Labels
Category: Open Source
The issue or pull reuqest is related to the open source packages of Tiptap.
Type: Bug
The issue or pullrequest is related to a bug
Comments
Mathias-S
added
Category: Open Source
The issue or pull reuqest is related to the open source packages of Tiptap.
Type: Bug
The issue or pullrequest is related to a bug
labels
Nov 21, 2024
5 tasks
Thanks for pointing this out. Resolved with: https://github.com/ueberdosis/tiptap/releases/tag/v2.10.1 |
5 tasks
1 task
gethari
pushed a commit
to gethari/tiptap
that referenced
this issue
Nov 23, 2024
…osis#5860) * revert: "fix(core): update the typings to be that options and storage are partials on an extended config ueberdosis#5852 (ueberdosis#5854)" This reverts commit 87d63d8. * revert: "fix(core): update the typing of `addOptions`, `addStorage` to have an optional parent ueberdosis#5768 (ueberdosis#5770)" This reverts commit d2f366d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category: Open Source
The issue or pull reuqest is related to the open source packages of Tiptap.
Type: Bug
The issue or pullrequest is related to a bug
Affected Packages
@tiptap/extension-link
Version(s)
2.10.0
Bug Description
When trying to extend certain extensions, such as
@tiptap/extension-link
, usingaddOptions
and...this.parent?.()
, v2.10.0 has introduced an error in code that previously worked fine:Browser Used
Chrome
Code Example URL
No response
Expected Behavior
Since this is very similar to code in the docs, I expect this to work without any errors. Alternatively, there should be another way to extend Link without having to provide all options.
Additional Context (Optional)
Probably a regression caused by the commits related to #5768
Dependency Updates
The text was updated successfully, but these errors were encountered: