You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, if you are using both the image extension, and the link extension, you can cause the editor to crash with an error by dragging an image into the editor.
Which browser was this experienced in? Are any special extensions installed?
Browser: Chrome latest.
Relevant extensions: image and link
How can we reproduce the bug on our side?
Have a look at the CodeSandbox. It appears as though the steps are:
Use ProseMirror with both the link and image extensions,
I've actually just discovered that even providing a button to add an image (as demo'd in the docs) will also break it. I've updated the code sandbox with a button. This makes me feel like I've done something wrong.
What’s the bug you are facing?
Right now, if you are using both the image extension, and the link extension, you can cause the editor to crash with an error by dragging an image into the editor.
Which browser was this experienced in? Are any special extensions installed?
Browser: Chrome latest.
Relevant extensions: image and link
How can we reproduce the bug on our side?
Have a look at the CodeSandbox. It appears as though the steps are:
Can you provide a CodeSandbox?
Here's a codesandbox https://codesandbox.io/s/small-thunder-k9wl2m?file=/src/App.vue
What did you expect to happen?
No error, but nothing in the editor should happen.
Anything to add? (optional)
Happy to raise a PR. My fix would be to add a check on the
nodesInChangedRange
array in the condition below to check that the array is not empty:https://github.com/ueberdosis/tiptap/blob/main/packages/extension-link/src/helpers/autolink.ts#L76-L79
Did you update your dependencies?
Are you sponsoring us?
The text was updated successfully, but these errors were encountered: