Extract images and team domain from identity only auth #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taj
approved these changes
Jul 29, 2019
|
@tajchumber I'm still fairly new to elixir, are my changes idiomatic? |
|
@ibash don't worry about it :) |
Hanspagh
requested changes
Jul 30, 2019
There was a problem hiding this comment.
Overall looks very good, I have one change request and one question.
For now the code looks either in the user or identity to find image_urls and team_image_urls, I am not fully into the slack API, but would it be possible that some image_urls would be in the user and some other image_urls would be in the identity and with this solution we would only parse some of them?
|
@Hanspagh I don't think so, because the |
When using sign in with slack the team domain and image urls are provided. This pulls them out into info and credentials.
|
@Hanspagh @doomspork updated! |
Hanspagh
approved these changes
Oct 23, 2019
|
Looks good to me @doomspork ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using sign in with slack the team domain and image urls are provided. This pulls them out into info and credentials.