MSIX: keep PowerRename local COM server in memory (microsoft#1222)

udit3333 · Feb 19, 2020 · 7d1c925 · 7d1c925
1 parent 6b0ffbb
commit 7d1c925
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/modules/powerrename/UWPui/PowerRenameUWPUI.cpp b/src/modules/powerrename/UWPui/PowerRenameUWPUI.cpp
@@ -18,7 +18,8 @@ void ModuleRelease()
 {
     if (--g_dwModuleRefCount == 0)
     {
-        PostThreadMessage(main_thread_id, WM_QUIT, 0, 0);
+        // Do nothing and keep the COM server in memory forever. We might want to introduce delayed shutdown and/or
+        // periodic polling whether a user has disabled us in settings. Tracking this in #1217
     }
 }
 HINSTANCE g_hInst = 0;
@@ -95,9 +96,9 @@ int APIENTRY wWinMain(_In_ HINSTANCE hInstance,
     main_thread_id = GetCurrentThreadId();
     winrt::init_apartment();
     g_hInst = hInstance;
-    auto factory = std::make_unique<CPowerRenameClassLocalFactory>(CLSID_PowerRenameMenu);
+    CPowerRenameClassLocalFactory factory{CLSID_PowerRenameMenu};
     DWORD token;
-    if (!SUCCEEDED(CoRegisterClassObject(CLSID_PowerRenameMenu, factory.get(), CLSCTX_LOCAL_SERVER, REGCLS_MULTIPLEUSE, &token)))
+    if (!SUCCEEDED(CoRegisterClassObject(CLSID_PowerRenameMenu, &factory, CLSCTX_LOCAL_SERVER, REGCLS_MULTIPLEUSE, &token)))
     {
         return 1;
     }