Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release year sometimes missing in search results #14

Open
OwenLaRosa opened this issue Nov 9, 2018 · 0 comments
Open

Release year sometimes missing in search results #14

OwenLaRosa opened this issue Nov 9, 2018 · 0 comments
Labels
moviemanagerchallenge Task for "Improve the Movie Manager" Challenge

Comments

@OwenLaRosa
Copy link
Contributor

The starter code for the Movie Manager, has a bug where a stray dash (-) appears for movies without a release year (see last result).

image

The fix just involves changing the line in SearchViewController that sets the label's text.

cell.textLabel?.text = "(movie.title) - (movie.releaseYear)"

One way to solve this is to just check if the string is empty before adding the year to the label's text. While not much of a "networking challenge", oftentimes, networked data may not include all the information you expect, and edge cases, like when the movie's release year is unknown, will ultimately come up.

@OwenLaRosa OwenLaRosa added the moviemanagerchallenge Task for "Improve the Movie Manager" Challenge label Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
moviemanagerchallenge Task for "Improve the Movie Manager" Challenge
Projects
None yet
Development

No branches or pull requests

1 participant