Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lists won't show more than 20 movies #13

Open
OwenLaRosa opened this issue Nov 9, 2018 · 0 comments
Open

Lists won't show more than 20 movies #13

OwenLaRosa opened this issue Nov 9, 2018 · 0 comments
Labels
moviemanagerchallenge Task for "Improve the Movie Manager" Challenge

Comments

@OwenLaRosa
Copy link
Contributor

When we get search results, or get the watchlist/favorites, the response we get back, and the MovieResults struct we decode into has properties for page, per_page, and total pages. How many movie results do you get per page? According to this discussion, only 20:
https://www.themoviedb.org/talk/587bea71c3a36846c300ff73

To handle watchlist/favorites lists with more than 20 movies, we need to download from multiple pages. We can specify the page using the page query parameter. And you can use the total_pages property in the response to know the number of pages to fetch. How to solve this is up to you: perhaps you download all the pages at once, or get a bit fancier and download the next page as the table scrolls to the bottom. In either case, users with more than 20 movies on their lists should be able to view all of them.

@OwenLaRosa OwenLaRosa added the moviemanagerchallenge Task for "Improve the Movie Manager" Challenge label Nov 9, 2018
BrentMifsud pushed a commit to BrentMifsud/TheMovieManager that referenced this issue Jun 2, 2019
BrentMifsud pushed a commit to BrentMifsud/TheMovieManager that referenced this issue Jun 2, 2019
BrentMifsud pushed a commit to BrentMifsud/TheMovieManager that referenced this issue Jun 2, 2019
BrentMifsud pushed a commit to BrentMifsud/TheMovieManager that referenced this issue Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
moviemanagerchallenge Task for "Improve the Movie Manager" Challenge
Projects
None yet
Development

No branches or pull requests

1 participant