This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Hot - Fix for SuspeciousFileOperation error on certificate preview. - #308
Merged
Merged
Conversation
tehreem-sadat
requested review from
HamzaIbnFarooq,
danialmalik,
mumarkhan999 and
tasawernawaz
February 21, 2020 13:52
tasawernawaz
approved these changes
Feb 21, 2020
danialmalik
approved these changes
Feb 24, 2020
There was a problem hiding this comment.
I think we should first verify that signature_image_path is starting with a / and only then truncate it. But if this is for the hotfix purposes only, then can be ignored for now I guess.
There was a problem hiding this comment.
I agree we should care about an edge case here, otherwise, it can raise an exception.
tehreem-sadat
force-pushed
the
tehreem/fix_preview_certificate_error
branch
from
February 24, 2020 07:18
fdaf1b7 to
b6fe96e
Compare
danialmalik
approved these changes
Feb 24, 2020
Comment on lines
481
to
483
There was a problem hiding this comment.
I think we don't need this part, do we?
HamzaIbnFarooq
approved these changes
Feb 24, 2020
tehreem-sadat
force-pushed
the
tehreem/fix_preview_certificate_error
branch
from
February 24, 2020 08:01
b6fe96e to
e459f3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story Link
244
PR Description
An error was due to extra starting "/" in the signatory image path. For now, I have removed that "/".
Type of change
Please select the options that are relevant.
How to test?
Steps:
Result:
The certificate should be displayed without any error.
Checklist before merging: