This repository was archived by the owner on Mar 25, 2025. It is now read-only.
EDS-233: Fixing python tests - #301
Merged
Merged
Conversation
…t_sent_if_disabled test
|
Hello @HamzaIbnFarooq! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-02-17 13:58:37 UTC |
HamzaIbnFarooq
force-pushed
the
hamza/EDS-233/Fix_python_tests
branch
from
February 17, 2020 07:05
5a57a2a to
8ba8561
Compare
HamzaIbnFarooq
force-pushed
the
hamza/EDS-233/Fix_python_tests
branch
from
February 17, 2020 07:24
d23af45 to
55bec9e
Compare
Author
|
jenkins run python |
|
Your PR has finished running tests. The following contexts failed:
|
Author
|
jenkins run python |
|
Your PR has finished running tests. The following contexts failed:
|
Author
|
jenkins run python |
Author
|
jenkins run python |
|
Your PR has finished running tests. There were no failures. |
HamzaIbnFarooq
requested review from
danialmalik,
imhassantariq,
mumarkhan999,
tasawernawaz and
tehreem-sadat
February 17, 2020 14:18
danialmalik
approved these changes
Feb 18, 2020
tehreem-sadat
approved these changes
Feb 25, 2020
mumarkhan999
approved these changes
Feb 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story Link
EDS-233
PR Description
After configuring python tests for edx-platform, we came to know that a few tests are failing. This PR is meant to fix all those tests.
List of currently failing tests
Type of change
Please select the options that are relevant.
How to test?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configurations.
Checklist before merging: