Skip to content

Sprint/24.02 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 188 commits into from
Feb 4, 2025
Merged

Sprint/24.02 #40

merged 188 commits into from
Feb 4, 2025

Conversation

MlKilderkin
Copy link
Contributor

@MlKilderkin MlKilderkin commented Nov 21, 2024

What does this do/fix?

Add news site functionality:

  1. New news Post Single template
  2. Post Header block
  3. Press Inquiries block
  4. Related Stories block
  5. Photo of the Week (PotW) CPT registered
  6. PotW Archive View added and single view disabled
  7. PotW block
  8. Media Coverage block
  9. Magazine block
  10. Featured News block
  11. Plugin dependency support added for Social Sharing and Post Terms.
    a. Adds new webpack config file for wp-scripts and a PHP controller to serve the stylesheets
  12. Updated NVM version to 20.18
  13. Updated NPM scripts for WP Scripts tasks

Note:

  • define( 'UCSC_NEWS_SITE', true ); should be set in wp-config.php in order to make new functionality work
  • The current PR is also based on the Register News block (#30) #32 work
  • Be sure to activate the Social Share plugin on the news site
  • Yoast SEO plugin required for primary category usage

MlKilderkin and others added 30 commits November 14, 2024 12:48
Co-authored-by: Brett Cooper <[email protected]>
…1/photo-of-the-week

# Conflicts:
#	src/Core.php
UCSC-166 Scaffolding and Featured block
@MlKilderkin MlKilderkin marked this pull request as ready for review December 19, 2024 17:37
@MlKilderkin MlKilderkin changed the base branch from main to sprint/24.01 December 19, 2024 17:41
@MlKilderkin
Copy link
Contributor Author

Please read the note in PR

Copy link
Member

@knice knice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MlKilderkin @Vinsanity We have a few questions about this PR before approving it:

  1. If an article does not have a featured image, and we select that article in a featured news block, related posts block, etc, saving the page fails.
  2. For the media coverage block (and others, I suppose), how do we configure it to grab the most recent posts, regardless of taxonomy?
  3. Pagination links for the Photo of the Week archive have a different design from date-based archive links?
  4. 'Key Takeaways' block. Did we leave it out of the scope of this work? No problem if we did. Jason and I could not remember.

@Vinsanity
Copy link
Contributor

@MlKilderkin @Vinsanity We have a few questions about this PR before approving it:

  1. If an article does not have a featured image, and we select that article in a featured news block, related posts block, etc, saving the page fails.
  2. For the media coverage block (and others, I suppose), how do we configure it to grab the most recent posts, regardless of taxonomy?
  3. Pagination links for the Photo of the Week archive have a different design from date-based archive links?
  4. 'Key Takeaways' block. Did we leave it out of the scope of this work? No problem if we did. Jason and I could not remember.

@knice Those are definitely some interesting bugs. We should sync up on Monday and go through these. Here's what I found so far.

  1. I tried this without a feature image and the page save just fine. There is nothing restricting posts if there is no featured image.
  2. That block is using the Query Loop block and by default it orders from new --> old. There are multiple posts types attached to that Query so I'm not sure I understand the issue fully.
  3. It seems to be appearing the same for me so maybe there's some cached blocks/content or CSS maybe?
  4. I don't believe we had a ticket for Key Takeaways but I'll check with Nick on that and let you know.

@knice knice merged commit d96fa02 into sprint/24.01 Feb 4, 2025
knice pushed a commit that referenced this pull request Feb 4, 2025
* Register News block (#30) + Sprint/24.02 (#40) Add news tools and features

* update scripts and adds base block files and config updates.
* Add assets build for the plugin
* upgrade wpscripts to the latest version.
* adds linting support and npm scripts updates for wpscripts.
* update block instructions.
* update dev watch task.
* Update assets enqueue
* adds nvmrc file.
* re-add news link items.
* adds more news button styles.
* adds layout setting styles.
* fix button styles.
* limit terms to 3 each.
* fix empty array issue.
* Add preview text for empty block in admin
* Fix wrong cache key
* Fix block issue with cache

Co-authored-by: Vinny Listrani <[email protected]>
Co-authored-by: Brett Cooper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants