-
Notifications
You must be signed in to change notification settings - Fork 1
Sprint/24.02 #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sprint/24.02 #40
Conversation
…1/photo-of-the-week
Co-authored-by: Brett Cooper <[email protected]>
…1/photo-of-the-week # Conflicts: # src/Core.php
UCSC-166 Scaffolding and Featured block
…1/photo-of-the-week
…ity into feature/UCSC-170/FE-photo-of-the-week
Fix/dqa round
Please read the note in PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MlKilderkin @Vinsanity We have a few questions about this PR before approving it:
- If an article does not have a featured image, and we select that article in a featured news block, related posts block, etc, saving the page fails.
- For the media coverage block (and others, I suppose), how do we configure it to grab the most recent posts, regardless of taxonomy?
- Pagination links for the Photo of the Week archive have a different design from date-based archive links?
- 'Key Takeaways' block. Did we leave it out of the scope of this work? No problem if we did. Jason and I could not remember.
@knice Those are definitely some interesting bugs. We should sync up on Monday and go through these. Here's what I found so far.
|
* Register News block (#30) + Sprint/24.02 (#40) Add news tools and features * update scripts and adds base block files and config updates. * Add assets build for the plugin * upgrade wpscripts to the latest version. * adds linting support and npm scripts updates for wpscripts. * update block instructions. * update dev watch task. * Update assets enqueue * adds nvmrc file. * re-add news link items. * adds more news button styles. * adds layout setting styles. * fix button styles. * limit terms to 3 each. * fix empty array issue. * Add preview text for empty block in admin * Fix wrong cache key * Fix block issue with cache Co-authored-by: Vinny Listrani <[email protected]> Co-authored-by: Brett Cooper <[email protected]>
What does this do/fix?
Add news site functionality:
a. Adds new webpack config file for wp-scripts and a PHP controller to serve the stylesheets
Note:
define( 'UCSC_NEWS_SITE', true );
should be set in wp-config.php in order to make new functionality work