Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hammer logging fixes #817

Merged
merged 1 commit into from
Nov 6, 2023
Merged

hammer logging fixes #817

merged 1 commit into from
Nov 6, 2023

Conversation

JoshSweaterGuy
Copy link
Contributor

Created atexit closing of hammer logging file in logging.py.

Related PRs / Issues

fixes issue where logs are empty due to not closing the file before program terminates

Type of change:

  • [ * ] Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • [ * ] Other

Contributor Checklist:

  • [ * ] Did you set master as the base branch?
  • [ * ] Did you state the type-of-change/impact?
  • [* ] Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

@harrisonliew harrisonliew added this pull request to the merge queue Nov 6, 2023
Merged via the queue into master with commit c841f91 Nov 6, 2023
3 checks passed
@harrisonliew harrisonliew deleted the logging_fixes_n23 branch November 6, 2023 00:45
nayiri-k pushed a commit that referenced this pull request Nov 13, 2023
Co-authored-by: Joshua Davis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants