Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings for Cadence tools to add command line arguments #787

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Settings for Cadence tools to add command line arguments #787

wants to merge 1 commit into from

Conversation

krabo0om
Copy link

Related PRs / Issues

#786

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer (but fully compatible)
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?

harrisonliew
harrisonliew requested changes May 10, 2023
View reviewed changes
Copy link
Contributor

@harrisonliew harrisonliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Approval is pending the small suggestion.

hammer/formal/conformal/__init__.py
lec_bin = self.get_setting("formal.conformal.conformal_lec_bin")
ccd_bin = self.get_setting("formal.conformal.conformal_ccd_bin")
lec_bin = self.get_setting("formal.conformal.conformal_lec_bin") + \
self.get_setting("formal.conformal.conformal_lec_bin_args")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't match the key in the defaults.yml below.

I think for the rest of them I'd prefer doing <tool>_extra_args for clarity instead of <tool>_bin_args or <tool>_args

@harrisonliew harrisonliew added enhancement Cadence Specific to a Cadence tool labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrisonliew harrisonliew harrisonliew requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Cadence Specific to a Cadence tool enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krabo0om @harrisonliew